Skip to content

Conversation

eigenmikem
Copy link
Contributor

@eigenmikem eigenmikem commented Jul 2, 2025

Motivation:

Unnecessary signature validation and confusing param name in ecdsa cert verifier.

Modifications:

Fixed

Result:

Contract cleaner and more efficient

@eigenmikem eigenmikem changed the title Fix/ecdsacertverifier parsesignatures fix: remove unnecessary signature validation and change param name Jul 2, 2025
Copy link
Contributor

@8sunyuan 8sunyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we also add the address[] signers in the return data for verifyCertificate?

@eigenmikem eigenmikem changed the title fix: remove unnecessary signature validation and change param name refactor: remove unnecessary signature validation and change param name Jul 7, 2025
@eigenmikem eigenmikem merged commit 0bb381d into main Jul 7, 2025
15 of 16 checks passed
@eigenmikem eigenmikem deleted the fix/ecdsacertverifier-parsesignatures branch July 7, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants