fix(audit): out-of-gas issue #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
force-pushed
the
fix/out-of-gas-issue
branch
from
d4a25b9 to
e987c51
Compare
|
Old PR: #1444 |
ypatil12
approved these changes
Jun 10, 2025
0xClandestine
merged commit 25cad96
into
release-dev/redistribution-changes
10 checks passed
0xClandestine
added a commit
that referenced
this pull request
Jul 1, 2025
**Motivation:** Previously, we stored `startBlock` and computed the `completeBlock` at runtime by iterating through the list of added strategies for a given `slashId`. This approach required recalculating the `completeBlock` each time. **Modifications:** We now store `completeBlock` directly instead of `startBlock`. During each call to `initiateSlashEscrow`, we compare the delay of the newly added strategy to the current `completeBlock` for the `slashId`. If the new delay is larger, we update `completeBlock` accordingly. This ensures that the maximum delay is always preserved. **Result:** The `completeBlock` for each `slashId` is now computed and maintained incrementally, eliminating the need for runtime iteration over all strategies.
0xClandestine
added a commit
that referenced
this pull request
Jul 2, 2025
**Motivation:** Previously, we stored `startBlock` and computed the `completeBlock` at runtime by iterating through the list of added strategies for a given `slashId`. This approach required recalculating the `completeBlock` each time. **Modifications:** We now store `completeBlock` directly instead of `startBlock`. During each call to `initiateSlashEscrow`, we compare the delay of the newly added strategy to the current `completeBlock` for the `slashId`. If the new delay is larger, we update `completeBlock` accordingly. This ensures that the maximum delay is always preserved. **Result:** The `completeBlock` for each `slashId` is now computed and maintained incrementally, eliminating the need for runtime iteration over all strategies.
0xClandestine
added a commit
that referenced
this pull request
Jul 2, 2025
**Motivation:** Previously, we stored `startBlock` and computed the `completeBlock` at runtime by iterating through the list of added strategies for a given `slashId`. This approach required recalculating the `completeBlock` each time. **Modifications:** We now store `completeBlock` directly instead of `startBlock`. During each call to `initiateSlashEscrow`, we compare the delay of the newly added strategy to the current `completeBlock` for the `slashId`. If the new delay is larger, we update `completeBlock` accordingly. This ensures that the maximum delay is always preserved. **Result:** The `completeBlock` for each `slashId` is now computed and maintained incrementally, eliminating the need for runtime iteration over all strategies.
ypatil12
pushed a commit
that referenced
this pull request
Jul 7, 2025
**Motivation:** Previously, we stored `startBlock` and computed the `completeBlock` at runtime by iterating through the list of added strategies for a given `slashId`. This approach required recalculating the `completeBlock` each time. **Modifications:** We now store `completeBlock` directly instead of `startBlock`. During each call to `initiateSlashEscrow`, we compare the delay of the newly added strategy to the current `completeBlock` for the `slashId`. If the new delay is larger, we update `completeBlock` accordingly. This ensures that the maximum delay is always preserved. **Result:** The `completeBlock` for each `slashId` is now computed and maintained incrementally, eliminating the need for runtime iteration over all strategies.
ypatil12
pushed a commit
that referenced
this pull request
Jul 8, 2025
**Motivation:** Previously, we stored `startBlock` and computed the `completeBlock` at runtime by iterating through the list of added strategies for a given `slashId`. This approach required recalculating the `completeBlock` each time. **Modifications:** We now store `completeBlock` directly instead of `startBlock`. During each call to `initiateSlashEscrow`, we compare the delay of the newly added strategy to the current `completeBlock` for the `slashId`. If the new delay is larger, we update `completeBlock` accordingly. This ensures that the maximum delay is always preserved. **Result:** The `completeBlock` for each `slashId` is now computed and maintained incrementally, eliminating the need for runtime iteration over all strategies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Previously, we stored
startBlockand computed thecompleteBlockat runtime by iterating through the list of added strategies for a givenslashId. This approach required recalculating thecompleteBlockeach time.Modifications:
We now store
completeBlockdirectly instead ofstartBlock. During each call toinitiateSlashEscrow, we compare the delay of the newly added strategy to the currentcompleteBlockfor theslashId. If the new delay is larger, we updatecompleteBlockaccordingly. This ensures that the maximum delay is always preserved.Result:
The
completeBlockfor eachslashIdis now computed and maintained incrementally, eliminating the need for runtime iteration over all strategies.