fix(audit): more reentrancy checks #1450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
changed the title
nadir-akhtar
approved these changes
Jun 9, 2025
ypatil12
approved these changes
Jun 9, 2025
ypatil12
requested changes
Jun 9, 2025
Plan to merge the other first and branch will auto update. |
Base automatically changed from
fix/out-of-gas-issue
to
release-dev/redistribution-changes
June 10, 2025 19:15
0xClandestine
force-pushed
the
fix/reentrancy
branch
from
25119e1 to
240da6a
Compare
0xClandestine
force-pushed
the
release-dev/redistribution-changes
branch
from
936ffe7 to
ecc3fdf
Compare
0xClandestine
force-pushed
the
fix/reentrancy
branch
from
240da6a to
0f6daeb
Compare
0xClandestine
force-pushed
the
fix/reentrancy
branch
from
0f6daeb to
99ef6fa
Compare
|
Are we sure storage layout isn't becoming clobbered? At least for testnet/preprod |
ypatil12
approved these changes
Jun 10, 2025
0xClandestine
merged commit 9159390
into
release-dev/redistribution-changes
12 of 15 checks passed
0xClandestine
added a commit
that referenced
this pull request
Jul 1, 2025
**Motivation:** Release functions did not have a `nonReentrant` check, and while code is well isolated it would be nice to prevent the concern entirely. **Modifications:** * Applied the `nonReentrant` modifier to both `releaseSlashEscrow` and `releaseSlashEscrowByStrategy` functions within the `SlashEscrowFactory` to prevent potential reentrancy vulnerabilities. * Relocated the `nonReentrant` modifier from `clearBurnOrRedistributableShares` to `clearBurnOrRedistributableSharesByStrategy` in the `StrategyManager` to ensure both methods are protected. **Result:** Less reentrancy-based security risk.
0xClandestine
added a commit
that referenced
this pull request
Jul 2, 2025
**Motivation:** Release functions did not have a `nonReentrant` check, and while code is well isolated it would be nice to prevent the concern entirely. **Modifications:** * Applied the `nonReentrant` modifier to both `releaseSlashEscrow` and `releaseSlashEscrowByStrategy` functions within the `SlashEscrowFactory` to prevent potential reentrancy vulnerabilities. * Relocated the `nonReentrant` modifier from `clearBurnOrRedistributableShares` to `clearBurnOrRedistributableSharesByStrategy` in the `StrategyManager` to ensure both methods are protected. **Result:** Less reentrancy-based security risk.
0xClandestine
added a commit
that referenced
this pull request
Jul 2, 2025
**Motivation:** Release functions did not have a `nonReentrant` check, and while code is well isolated it would be nice to prevent the concern entirely. **Modifications:** * Applied the `nonReentrant` modifier to both `releaseSlashEscrow` and `releaseSlashEscrowByStrategy` functions within the `SlashEscrowFactory` to prevent potential reentrancy vulnerabilities. * Relocated the `nonReentrant` modifier from `clearBurnOrRedistributableShares` to `clearBurnOrRedistributableSharesByStrategy` in the `StrategyManager` to ensure both methods are protected. **Result:** Less reentrancy-based security risk.
ypatil12
pushed a commit
that referenced
this pull request
Jul 7, 2025
**Motivation:** Release functions did not have a `nonReentrant` check, and while code is well isolated it would be nice to prevent the concern entirely. **Modifications:** * Applied the `nonReentrant` modifier to both `releaseSlashEscrow` and `releaseSlashEscrowByStrategy` functions within the `SlashEscrowFactory` to prevent potential reentrancy vulnerabilities. * Relocated the `nonReentrant` modifier from `clearBurnOrRedistributableShares` to `clearBurnOrRedistributableSharesByStrategy` in the `StrategyManager` to ensure both methods are protected. **Result:** Less reentrancy-based security risk.
ypatil12
pushed a commit
that referenced
this pull request
Jul 8, 2025
**Motivation:** Release functions did not have a `nonReentrant` check, and while code is well isolated it would be nice to prevent the concern entirely. **Modifications:** * Applied the `nonReentrant` modifier to both `releaseSlashEscrow` and `releaseSlashEscrowByStrategy` functions within the `SlashEscrowFactory` to prevent potential reentrancy vulnerabilities. * Relocated the `nonReentrant` modifier from `clearBurnOrRedistributableShares` to `clearBurnOrRedistributableSharesByStrategy` in the `StrategyManager` to ensure both methods are protected. **Result:** Less reentrancy-based security risk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Release functions did not have a
nonReentrantcheck, and while code is well isolated it would be nice to prevent the concern entirely.Modifications:
Applied the
nonReentrantmodifier to bothreleaseSlashEscrowandreleaseSlashEscrowByStrategyfunctions within theSlashEscrowFactoryto prevent potential reentrancy vulnerabilities.Relocated the
nonReentrantmodifier fromclearBurnOrRedistributableSharestoclearBurnOrRedistributableSharesByStrategyin theStrategyManagerto ensure both methods are protected.Result:
Less reentrancy-based security risk.