refactor: decreaseBurnOrRedistributableShares
#1414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
force-pushed
the
refactor/decreaseBurnOrRedistributableShares
branch
from
a3bcba8 to
41adb7b
Compare
0xClandestine
changed the title
AllocationManager redistribution support (#1346)decreaseBurnOrRedistributableShares
ypatil12
approved these changes
May 27, 2025
ypatil12
requested changes
May 27, 2025
0xClandestine
added a commit
that referenced
this pull request
May 27, 2025
**Motivation:** With the addition of non-arrified versions of `decreaseBurnableShares` and `releaseSlashEscrow` we want to avoid the use of `EnumerableSet.at()` as it reverts when attempting to retrieve indices that do not exist (> length). **Modifications:** - Use `EnumerableSet.tryGet` and `EnumerableSet.keys` instead which does not revert (but simply does nothing) if the index doesn't exist. - Rename `decreaseBurnOrRedistributableShares` -> `clearBurnOrRedistributableShares` to better reflect the functions purpose. **Result:** Protocol guarantees are maintained, and better naming.
0xClandestine
added a commit
that referenced
this pull request
May 30, 2025
**Motivation:** With the addition of non-arrified versions of `decreaseBurnableShares` and `releaseSlashEscrow` we want to avoid the use of `EnumerableSet.at()` as it reverts when attempting to retrieve indices that do not exist (> length). **Modifications:** - Use `EnumerableSet.tryGet` and `EnumerableSet.keys` instead which does not revert (but simply does nothing) if the index doesn't exist. - Rename `decreaseBurnOrRedistributableShares` -> `clearBurnOrRedistributableShares` to better reflect the functions purpose. **Result:** Protocol guarantees are maintained, and better naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
With the addition of non-arrified versions of
decreaseBurnableSharesandreleaseSlashEscrowwe want to avoid the use ofEnumerableSet.at()as it reverts when attempting to retrieve indices that do not exist (> length).Modifications:
EnumerableSet.tryGetandEnumerableSet.keysinstead which does not revert (but simply does nothing) if the index doesn't exist.decreaseBurnOrRedistributableShares->clearBurnOrRedistributableSharesto better reflect the functions purpose.Result:
Protocol guarantees are maintained, and better naming.