feat: deploy escrow in initiateSlashEscrow
#1413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
approved these changes
May 27, 2025
0xClandestine
pushed a commit
that referenced
this pull request
May 27, 2025
**Motivation:** For clarity, let's deploy the `SlashEscrow` in `initiateEscrow`. **Modifications:** 1. In `initiateEscrow `, deploy the `SlashEscrow` if it hasn't been deployed 2. Also add the startBlock, opSet to pending, and slashId to pending in this if block **Result:** No more counterfactual. Less redundant updates for multiple strategies in a slashID.
0xClandestine
pushed a commit
that referenced
this pull request
May 30, 2025
**Motivation:** For clarity, let's deploy the `SlashEscrow` in `initiateEscrow`. **Modifications:** 1. In `initiateEscrow `, deploy the `SlashEscrow` if it hasn't been deployed 2. Also add the startBlock, opSet to pending, and slashId to pending in this if block **Result:** No more counterfactual. Less redundant updates for multiple strategies in a slashID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
For clarity, let's deploy the
SlashEscrowininitiateEscrow.Modifications:
initiateEscrow, deploy theSlashEscrowif it hasn't been deployedResult:
No more counterfactual. Less redundant updates for multiple strategies in a slashID.