Skip to content

Conversation

@mimowo
Copy link
Contributor

@mimowo mimowo commented Oct 16, 2024

Description

This is a placeholder PR to update docs as JobManagedBy graduates to Beta. The code PR is already merged kubernetes/kubernetes#127402.

Issue

Part of kubernetes/enhancements#4368

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2024
@mimowo mimowo changed the title Update docs as JobManagedBy graduates to Beta Update docs as JobManagedBy graduates to Beta [PLACEHOLDER] Oct 16, 2024
@netlify
Copy link

netlify bot commented Oct 16, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2c93c92
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6715f252d39a8400089dbc0a

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2024
@netlify
Copy link

netlify bot commented Oct 16, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2c93c92
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6715f25217e0c100084defc5
😎 Deploy Preview https://deploy-preview-48378--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Oct 16, 2024

/retitle [WIP] Update docs as JobManagedBy graduates to Beta

@k8s-ci-robot k8s-ci-robot changed the title Update docs as JobManagedBy graduates to Beta [PLACEHOLDER] [WIP] Update docs as JobManagedBy graduates to Beta Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@sftim
Copy link
Contributor

sftim commented Oct 16, 2024

Once ready for review, please mark this as not-WIP.

@mimowo mimowo force-pushed the update-job-managed-by-to-beta branch from 7bd7b22 to 4f7eb7c Compare October 17, 2024 07:17
@tengqm
Copy link
Contributor

tengqm commented Oct 17, 2024

Change looks good, but I think we need to change content/en/docs/concepts/workloads/controllers/job.md as well.

@mimowo mimowo force-pushed the update-job-managed-by-to-beta branch from 4f7eb7c to 2c93c92 Compare October 21, 2024 06:18
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Oct 21, 2024

Sure, I just pushed today an update controllers/job.md that follows from the default change. PTAL.

@mimowo mimowo changed the title [WIP] Update docs as JobManagedBy graduates to Beta Update docs as JobManagedBy graduates to Beta Oct 21, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024
@tengqm
Copy link
Contributor

tengqm commented Oct 22, 2024

Docs lgtm.
@mimowo Please provide a link to the upstream source code change, so that reviewers/approvers can see if the change has landed and the hold can be lifted.
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Oct 22, 2024

Sure, I just updated the description to link the code PR which bumped the gate status: kubernetes/kubernetes#127402

@tengqm
Copy link
Contributor

tengqm commented Oct 22, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fcc9aaa5b0f7c5fbd217a87037e69990f325d6a1

@tengqm
Copy link
Contributor

tengqm commented Oct 22, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit e3f0368 into kubernetes:dev-1.32 Oct 22, 2024
6 checks passed
This was referenced Dec 12, 2024
Andygol pushed a commit to Andygol/k8s-website that referenced this pull request Dec 31, 2024
Keep it consistent with the original text and optimize the Chinese description

Original link: kubernetes#48378
rayandas pushed a commit to rayandas/website that referenced this pull request Jan 24, 2025
Keep it consistent with the original text and optimize the Chinese description

Original link: kubernetes#48378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants