Skip to content

Commit 5df9a0b

Browse files
authored
Merge pull request #5467 from macsko/update_nnn_kep_to_alpha
KEP-5278: Update the KEP to reflect its demotion to alpha
2 parents 08972ff + ce83e57 commit 5df9a0b

File tree

3 files changed

+17
-8
lines changed

3 files changed

+17
-8
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
kep-number: 5278
2-
beta:
2+
alpha:
33
approver: "@soltysh"

keps/sig-scheduling/5278-nominated-node-name-for-expectation/README.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -578,11 +578,12 @@ and an e2e test wouldn't add any additional value.
578578

579579
**Upgrade**
580580

581-
During the beta period, the feature gate `NominatedNodeNameForExpectation` is enabled by default, so users don't need to opt in.
581+
During the alpha period, the feature gates `NominatedNodeNameForExpectation` and `ClearingNominatedNodeNameAfterBinding` are disabled by default,
582+
so users have to enable the gates to opt in.
582583

583584
**Downgrade**
584585

585-
Users need to disable the feature gate, and restart kube-scheduler and kube-apiserver.
586+
Users need to disable the feature gates, and restart kube-scheduler and kube-apiserver.
586587

587588
On downgrade to the version that doesn't have this feature, there aren't any action that users need to take. For pods that have NominatedNodeName set, scheduler will try to honor it, but:
588589
- if the pod is still not schedulable, it will clear the field
@@ -616,7 +617,11 @@ which is fine by the today's scheduler implementation as well.
616617

617618
- [x] Feature gate (also fill in values in `kep.yaml`)
618619
- Feature gate name: NominatedNodeNameForExpectation
619-
- Components depending on the feature gate: kube-scheduler, kube-apiserver
620+
- Components depending on the feature gate: kube-scheduler
621+
- [x] Feature gate
622+
- Feature gate name: ClearingNominatedNodeNameAfterBinding
623+
- Components depending on the feature gate: kube-apiserver
624+
620625

621626
###### Does enabling the feature change any default behavior?
622627

@@ -625,7 +630,7 @@ Pods that are processed by Permit or PreBind plugins get NominatedNodeName durin
625630
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
626631

627632
Yes.
628-
The feature can be disabled in Beta version by restarting the kube-scheduler and kube-apiserver with the feature-gate off.
633+
The feature can be disabled in Alpha version by restarting the kube-scheduler and kube-apiserver with the feature-gate off.
629634

630635
###### What happens if we reenable the feature if it was previously rolled back?
631636

@@ -769,6 +774,7 @@ Unknown.
769774
## Implementation History
770775

771776
- 7th May 2025: The initial KEP is submitted.
777+
- 31st Jul 2025: The enhancement was demoted to alpha, because it haven't met all beta requirements for v1.34.
772778

773779
## Drawbacks
774780

keps/sig-scheduling/5278-nominated-node-name-for-expectation/kep.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,21 @@ approvers:
1515
- "@macsko"
1616
- "@dom4ha"
1717

18-
stage: beta
18+
stage: alpha
1919

2020
latest-milestone: "v1.34"
2121

2222
milestone:
23-
beta: "v1.34"
24-
stable: "v1.36"
23+
alpha: "v1.34"
24+
beta: "v1.35"
25+
stable: "v1.37"
2526

2627
feature-gates:
2728
- name: NominatedNodeNameForExpectation
2829
components:
2930
- kube-scheduler
31+
- name: ClearingNominatedNodeNameAfterBinding
32+
components:
3033
- kube-apiserver
3134
disable-supported: true
3235

0 commit comments

Comments
 (0)