adds DATACRUNCH_STARTUP_SCRIPT_FILE env var

Author: maaft

cluster-autoscaler/cloudprovider/datacrunch/README.md

@@ -78,6 +78,7 @@ DATACRUNCH_CLUSTER_CONFIG_FILE="/path/to/config.json"    # File path
 
 # Optional: Startup script configuration
 DATACRUNCH_STARTUP_SCRIPT="#!/bin/bash\necho 'Hello World'"  # Global startup script
+DATACRUNCH_STARTUP_SCRIPT_FILE="<path to file>"              # Is only read when DATACRUNCH_STARTUP_SCRIPT is empty
 DATACRUNCH_DELETE_SCRIPTS_AFTER_BOOT="true"                  # Auto-delete scripts after execution
 ```
 
@@ -197,7 +198,7 @@ spec:
 You can configure startup scripts in three ways (in order of precedence):
 
 1. **Per-nodepool scripts** (highest precedence): Set `startup_script_base64` in nodepool configuration
-2. **Global startup script**: Set `DATACRUNCH_STARTUP_SCRIPT` environment variable
+2. **Global startup script**: Set `DATACRUNCH_STARTUP_SCRIPT` or `DATACRUNCH_STARTUP_SCRIPT_FILE` environment variables. `DATACRUNCH_STARTUP_SCRIPT` takes precedence.
 3. **No startup script**: Instances will boot with default image configuration
 
 Example per-nodepool script configuration:

cluster-autoscaler/cloudprovider/datacrunch/datacrunch_manager.go

@@ -41,7 +41,6 @@ type datacrunchManager struct {
 	clusterConfig    *ClusterConfig
 	cachedServerType *serverTypeCache
 	cachedServers    *serversCache
-	startupScript    string
 }
 
 // ClusterConfig holds the configuration for all the nodepools
@@ -102,7 +101,6 @@ func newManager() (*datacrunchManager, error) {
 	clusterConfigBase64 := os.Getenv("DATACRUNCH_CLUSTER_CONFIG")
 	clusterConfigBaseJSON := os.Getenv("DATACRUNCH_CLUSTER_CONFIG_JSON")
 	clusterConfigFile := os.Getenv("DATACRUNCH_CLUSTER_CONFIG_FILE")
-	startupScript := os.Getenv("DATACRUNCH_STARTUP_SCRIPT")
 
 	if clusterConfigBase64 == "" && clusterConfigFile == "" && clusterConfigBaseJSON == "" {
 		return nil, errors.New("one of `DATACRUNCH_CLUSTER_CONFIG`, `DATACRUNCH_CLUSTER_CONFIG_FILE` or `DATACRUNCH_CLUSTER_CONFIG_JSON` must be specified")
@@ -137,7 +135,6 @@ func newManager() (*datacrunchManager, error) {
 		clusterConfig:    clusterConfig,
 		cachedServerType: newServerTypeCache(ctx, client),
 		cachedServers:    newServersCache(ctx, client),
-		startupScript:    startupScript,
 	}
 
 	return m, nil

cluster-autoscaler/cloudprovider/datacrunch/datacrunch_node_group.go

@@ -609,7 +609,16 @@ func createServer(n *datacrunchNodeGroup) error {
 	startupScriptName := fmt.Sprintf("autoscaler-startup-script-%s", nodeName)
 
 	var startupScriptID string
-	startupScript := n.manager.startupScript
+	startupScript := os.Getenv("DATACRUNCH_STARTUP_SCRIPT")
+	startupScriptFile := os.Getenv("DATACRUNCH_STARTUP_SCRIPT_FILE")
+	if startupScript == "" && startupScriptFile != "" {
+		startupScriptBytes, err := os.ReadFile(startupScriptFile)
+		if err != nil {
+			return fmt.Errorf("failed to read startup script file: %v", err)
+		}
+		startupScript = string(startupScriptBytes)
+	}
+
 	if n.manager.clusterConfig.NodeConfigs[n.id].StartupScriptBase64 != "" {
 		startupScriptBytes, err := base64.StdEncoding.DecodeString(n.manager.clusterConfig.NodeConfigs[n.id].StartupScriptBase64)
 		if err != nil {