Skip to content

Commit 7b2d468

Browse files
committed
Increase range for expected VPA CPU recommendations in e2e
These tests can get flaky because the resource consumer consumes 1800 m CPU which can be unevenly distributed across 3 pods which can lead to failure. Also the tests dont need to append recommendations since vpa-recommender is running in this suite.
1 parent c187e7f commit 7b2d468

File tree

1 file changed

+3
-24
lines changed

1 file changed

+3
-24
lines changed

vertical-pod-autoscaler/e2e/v1/full_vpa.go

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,6 @@ var _ = FullVpaE2eDescribe("Pods under VPA", func() {
9191
WithTargetRef(targetRef).
9292
WithContainer(containerName).
9393
WithUpdateMode(vpa_types.UpdateModeInPlaceOrRecreate).
94-
AppendRecommendation(
95-
test.Recommendation().
96-
WithContainer(containerName).
97-
WithTarget("250m", "200Mi").
98-
WithLowerBound("250m", "200Mi").
99-
WithUpperBound("250m", "200Mi").
100-
GetContainerResources()).
10194
Get()
10295

10396
InstallVPA(f, vpaCRD)
@@ -114,7 +107,7 @@ var _ = FullVpaE2eDescribe("Pods under VPA", func() {
114107
rc.ConsumeCPU(600 * replicas)
115108
err = waitForResourceRequestInRangeInPods(
116109
f, pollTimeout, metav1.ListOptions{LabelSelector: "name=hamster"}, apiv1.ResourceCPU,
117-
ParseQuantityOrDie("500m"), ParseQuantityOrDie("1300m"))
110+
ParseQuantityOrDie("600m"), ParseQuantityOrDie("1800m"))
118111
gomega.Expect(err).NotTo(gomega.HaveOccurred())
119112
})
120113

@@ -162,13 +155,6 @@ var _ = FullVpaE2eDescribe("Pods under VPA", func() {
162155
WithNamespace(f.Namespace.Name).
163156
WithTargetRef(targetRef).
164157
WithContainer(containerName).
165-
AppendRecommendation(
166-
test.Recommendation().
167-
WithContainer(containerName).
168-
WithTarget("250m", "200Mi").
169-
WithLowerBound("250m", "200Mi").
170-
WithUpperBound("250m", "200Mi").
171-
GetContainerResources()).
172158
Get()
173159

174160
InstallVPA(f, vpaCRD)
@@ -185,7 +171,7 @@ var _ = FullVpaE2eDescribe("Pods under VPA", func() {
185171
rc.ConsumeCPU(600 * replicas)
186172
err = waitForResourceRequestInRangeInPods(
187173
f, pollTimeout, metav1.ListOptions{LabelSelector: "name=hamster"}, apiv1.ResourceCPU,
188-
ParseQuantityOrDie("500m"), ParseQuantityOrDie("1300m"))
174+
ParseQuantityOrDie("600m"), ParseQuantityOrDie("1800m"))
189175
gomega.Expect(err).NotTo(gomega.HaveOccurred())
190176
})
191177

@@ -248,13 +234,6 @@ var _ = FullVpaE2eDescribe("Pods under VPA with default recommender explicitly c
248234
WithNamespace(f.Namespace.Name).
249235
WithTargetRef(targetRef).
250236
WithContainer(containerName).
251-
AppendRecommendation(
252-
test.Recommendation().
253-
WithContainer(containerName).
254-
WithTarget("250m", "200Mi").
255-
WithLowerBound("250m", "200Mi").
256-
WithUpperBound("250m", "200Mi").
257-
GetContainerResources()).
258237
Get()
259238

260239
InstallVPA(f, vpaCRD)
@@ -272,7 +251,7 @@ var _ = FullVpaE2eDescribe("Pods under VPA with default recommender explicitly c
272251
rc.ConsumeCPU(600 * replicas)
273252
err = waitForResourceRequestInRangeInPods(
274253
f, pollTimeout, metav1.ListOptions{LabelSelector: "name=hamster"}, apiv1.ResourceCPU,
275-
ParseQuantityOrDie("500m"), ParseQuantityOrDie("1300m"))
254+
ParseQuantityOrDie("600m"), ParseQuantityOrDie("1800m"))
276255
gomega.Expect(err).NotTo(gomega.HaveOccurred())
277256
})
278257
})

0 commit comments

Comments
 (0)