Merge pull request #8007 from omerap12/fixed-lint-context

k8s-ci-robot · web-flow · commit 3e92831089c6 · 2025-04-03T07:56:47.000-07:00
fix lint: update tests with context
diff --git a/vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder_test.go b/vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder_test.go
@@ -600,11 +600,12 @@ type fakeMetricsClient struct {
 	snapshots []*metrics.ContainerMetricsSnapshot
 }
 
-func (m fakeMetricsClient) GetContainersMetrics() ([]*metrics.ContainerMetricsSnapshot, error) {
+func (m fakeMetricsClient) GetContainersMetrics(_ context.Context) ([]*metrics.ContainerMetricsSnapshot, error) {
 	return m.snapshots, nil
 }
 
 func TestClusterStateFeeder_LoadRealTimeMetrics(t *testing.T) {
+	_, tctx := ktesting.NewTestContext(t)
 	namespaceName := "test-namespace"
 	podID := model.PodID{Namespace: namespaceName, PodName: "Pod"}
 	regularContainer1 := model.ContainerID{PodID: podID, ContainerName: "Container1"}
@@ -639,7 +640,7 @@ func TestClusterStateFeeder_LoadRealTimeMetrics(t *testing.T) {
 		metricsClient:  fakeMetricsClient{snapshots: containerMetricsSnapshots},
 	}
 
-	feeder.LoadRealTimeMetrics()
+	feeder.LoadRealTimeMetrics(tctx)
 
 	assert.Equal(t, 2, len(clusterState.addedSamples))
 

Original file line number	Diff line number	Diff line change
`@@ -600,11 +600,12 @@ type fakeMetricsClient struct {`
`600`	`600`	`snapshots []*metrics.ContainerMetricsSnapshot`
`601`	`601`	`}`
`602`	`602`
`603`		`-func (m fakeMetricsClient) GetContainersMetrics() ([]*metrics.ContainerMetricsSnapshot, error) {`
	`603`	`+func (m fakeMetricsClient) GetContainersMetrics(_ context.Context) ([]*metrics.ContainerMetricsSnapshot, error) {`
`604`	`604`	`return m.snapshots, nil`
`605`	`605`	`}`
`606`	`606`
`607`	`607`	`func TestClusterStateFeeder_LoadRealTimeMetrics(t *testing.T) {`
	`608`	`+ _, tctx := ktesting.NewTestContext(t)`
`608`	`609`	`namespaceName := "test-namespace"`
`609`	`610`	`podID := model.PodID{Namespace: namespaceName, PodName: "Pod"}`
`610`	`611`	`regularContainer1 := model.ContainerID{PodID: podID, ContainerName: "Container1"}`
`@@ -639,7 +640,7 @@ func TestClusterStateFeeder_LoadRealTimeMetrics(t *testing.T) {`
`639`	`640`	`metricsClient: fakeMetricsClient{snapshots: containerMetricsSnapshots},`
`640`	`641`	`}`
`641`	`642`
`642`		`- feeder.LoadRealTimeMetrics()`
	`643`	`+ feeder.LoadRealTimeMetrics(tctx)`
`643`	`644`
`644`	`645`	`assert.Equal(t, 2, len(clusterState.addedSamples))`
`645`	`646`