CI checks

Author: maaft

cluster-autoscaler/cloudprovider/datacrunch/README.md

@@ -123,7 +123,7 @@ Configure node pools via JSON configuration:
 | `taints` | []object | Kubernetes taints that created nodes will have |
 | `labels` | map | Labels that created nodes will have |
 
-**Note**: It's your responsibilty to make sure that override_num_gpus (if used), taints and labels are correct. This is usually done as part of your startup-script.
+**Note**: It's your responsibility to make sure that override_num_gpus (if used), taints and labels are correct. This is usually done as part of your startup-script.
 
 ### Command Line Arguments
 

cluster-autoscaler/cloudprovider/datacrunch/datacrunch-go/types.go

@@ -33,36 +33,35 @@ type Instance struct {
 	Pricing       string   `json:"pricing"`
 }
 
+// CPU represents a CPU in DataCrunch.
 type CPU struct {
 	Description   string `json:"description"`
 	NumberOfCores int    `json:"number_of_cores"`
 }
 
+// GPU represents a GPU in DataCrunch.
 type GPU struct {
 	Description  string `json:"description"`
 	NumberOfGPUs int    `json:"number_of_gpus"`
 }
 
+// GPUMem represents a GPU memory in DataCrunch.
 type GPUMem struct {
 	Description     string `json:"description"`
 	SizeInGigabytes int    `json:"size_in_gigabytes"`
 }
 
+// Memory represents a memory in DataCrunch.
 type Memory struct {
 	Description     string `json:"description"`
 	SizeInGigabytes int    `json:"size_in_gigabytes"`
 }
 
+// Storage represents a storage in DataCrunch.
 type Storage struct {
 	Description string `json:"description"`
 }
 
-type Location struct {
-	Code        string `json:"code"`
-	Name        string `json:"name"`
-	CountryCode string `json:"country_code"`
-}
-
 // InstanceList is a list of instances.
 type InstanceList []Instance
 
@@ -84,11 +83,13 @@ type DeployInstanceRequest struct {
 	Pricing         string         `json:"pricing,omitempty"`
 }
 
+// OSVolume represents an OS volume in DataCrunch when creating a new instance.
 type OSVolume struct {
 	Name string `json:"name"`
 	Size int    `json:"size"`
 }
 
+// DeployVolume represents a deploy volume in DataCrunch when creating a new instance.
 type DeployVolume struct {
 	Name string `json:"name"`
 	Size int    `json:"size"`
@@ -131,6 +132,7 @@ type InstanceType struct {
 	DisplayName         string   `json:"display_name"`
 }
 
+// InstanceTypeList is a list of instance types.
 type InstanceTypeList []InstanceType
 
 // PriceHistoryEntry represents a price history entry for an instance type.
@@ -141,6 +143,7 @@ type PriceHistoryEntry struct {
 	Currency            string  `json:"currency"`
 }
 
+// PriceHistory is a map of instance types to price history entries.
 type PriceHistory map[string][]PriceHistoryEntry
 
 // InstanceAvailability represents instance availability for a location.
@@ -149,6 +152,7 @@ type InstanceAvailability struct {
 	Availabilities []string `json:"availabilities"`
 }
 
+// InstanceAvailabilityList is a list of instance availabilities.
 type InstanceAvailabilityList []InstanceAvailability
 
 // StartupScript represents a startup script in DataCrunch.

cluster-autoscaler/cloudprovider/datacrunch/datacrunch_manager.go

@@ -48,19 +48,27 @@ type ClusterConfig struct {
 	NodeConfigs map[string]*NodeConfig `json:"node_configs"`
 }
 
+// InstanceOption is the option for the instance type
 type InstanceOption string
 
 const (
-	InstanceOptionPreferSpot     InstanceOption = "prefer_spot"
+	// InstanceOptionPreferSpot is the option to prefer spot instances
+	InstanceOptionPreferSpot InstanceOption = "prefer_spot"
+	// InstanceOptionPreferOnDemand is the option to prefer on-demand instances
 	InstanceOptionPreferOnDemand InstanceOption = "prefer_on_demand"
-	InstanceOptionSpotOnly       InstanceOption = "spot_only"
-	InstanceOptionOnDemandOnly   InstanceOption = "on_demand_only"
+	// InstanceOptionSpotOnly is the option to only use spot instances
+	InstanceOptionSpotOnly InstanceOption = "spot_only"
+	// InstanceOptionOnDemandOnly is the option to only use on-demand instances
+	InstanceOptionOnDemandOnly InstanceOption = "on_demand_only"
 )
 
+// PricingOption is the option for the pricing type
 type PricingOption string
 
 const (
-	PricingOptionFixed   PricingOption = "fixed"
+	// PricingOptionFixed is the option to use fixed pricing
+	PricingOptionFixed PricingOption = "fixed"
+	// PricingOptionDynamic is the option to use dynamic pricing
 	PricingOptionDynamic PricingOption = "dynamic"
 )
 

cluster-autoscaler/cloudprovider/datacrunch/datacrunch_node_group.go

@@ -39,6 +39,7 @@ import (
 )
 
 const (
+	// ResourceGPU is the resource name for GPU
 	ResourceGPU apiv1.ResourceName = "nvidia.com/gpu"
 )
 

cluster-autoscaler/cloudprovider/datacrunch/examples/startup-script-server.go

@@ -12,15 +12,6 @@ import (
 	datacrunchclient "k8s.io/autoscaler/cluster-autoscaler/cloudprovider/datacrunch/datacrunch-go"
 )
 
-type ScriptRequest struct {
-	// Optionally allow overrides in the future
-}
-
-type ScriptResponse struct {
-	Script   string `json:"script"`
-	ScriptID string `json:"script_id"`
-}
-
 func main() {
 	http.HandleFunc("/script", handleGenerateScript)
 	port := os.Getenv("PORT")