Skip to content

Commit 10b0751

Browse files
committed
Fix CA's command
1 parent 24ba0e7 commit 10b0751

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

cluster-autoscaler/Makefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
ALL_ARCH = amd64 arm64 s390x
22
all: $(addprefix build-arch-,$(ALL_ARCH))
33

4+
# TODO: #8127 - Use default analyzers set by `go test` to include `printf` analyzer.
5+
# Default analyzers that go test runs according to https://github.com/golang/go/blob/52624e533fe52329da5ba6ebb9c37712048168e0/src/cmd/go/internal/test/test.go#L649
6+
# This doesn't include the `printf` analyzer until cluster-autoscaler libraries are updated.
7+
GO_TEST_DEFAULT_ANALYZERS?=atomic,bool,buildtags,directive,errorsas,ifaceassert,nilfunc,slog,stringintconv,tests
48
TAG?=dev
59
FLAGS=
610
LDFLAGS?=-s
@@ -129,7 +133,7 @@ container-arch-%: build-in-docker-arch-% make-image-arch-%
129133
@echo "Full in-docker image ${TAG}${FOR_PROVIDER}-$* completed"
130134

131135
test-in-docker: clean docker-builder
132-
docker run ${RM_FLAG} -v `pwd`:/cluster-autoscaler/:Z autoscaling-builder:latest bash -c 'cd /cluster-autoscaler && go test -race ./... ${TAGS_FLAG}'
136+
docker run ${RM_FLAG} -v `pwd`:/cluster-autoscaler/:Z autoscaling-builder:latest bash -c 'cd /cluster-autoscaler && go test -race ./... -vet="${GO_TEST_DEFAULT_ANALYZERS}" ${TAGS_FLAG}' \
133137

134138
.PHONY: all build test-unit clean format execute-release dev-release docker-builder build-in-docker release generate push-image push-manifest
135139

0 commit comments

Comments
 (0)