Support Helm Chart in KWOK #1020
yuanchen8911
started this conversation in
Ideas
Replies: 1 comment
-
I think we should support both the original go templates and helm charts. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
It would be great if
KWOK
could supportHelm charts
. I had a brief discussion with @wzshiming on Slack, and here's a summary.The main issue arises from the conflict with the
go
template's{{
and}}
. SinceHelm charts
also use these as default values,KWOK
would need to support modifying the default{{
and}}
. This change is straightforward but requires modification at every occurrence.To enable coexistence between the two, there are two options:
kustomize
withHelm
, as detailed here: https://helm.sh/docs/topics/advanced/#post-renderingHelm
withkustomize
, as detailed here: https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/helmchartsOption 2 (integrating
Helm
intokustomize
) appears to be the more feasible solution.@dmitsh, what are your thoughts on this?
Beta Was this translation helpful? Give feedback.
All reactions