Skip to content

Commit a069bf1

Browse files
authored
Merge pull request #5056 from lpmi-13/patch-1
🐛 (go/v4) fix simple typos in Dockerfile comments
2 parents d90d602 + 5357101 commit a069bf1

File tree

7 files changed

+7
-7
lines changed

7 files changed

+7
-7
lines changed

docs/book/src/cronjob-tutorial/testdata/project/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ COPY api/ api/
1717
COPY internal/ internal/
1818

1919
# Build
20-
# the GOARCH has not a default value to allow the binary be built according to the host where the command
20+
# the GOARCH has no default value to allow the binary to be built according to the host where the command
2121
# was called. For example, if we call make docker-build in a local env which has the Apple Silicon M1 SO
2222
# the docker BUILDPLATFORM arg will be linux/arm64 when for Apple x86 it will be linux/amd64. Therefore,
2323
# by leaving it empty we can ensure that the container and binary shipped on it will have the same platform.

docs/book/src/getting-started/testdata/project/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ COPY api/ api/
1717
COPY internal/ internal/
1818

1919
# Build
20-
# the GOARCH has not a default value to allow the binary be built according to the host where the command
20+
# the GOARCH has no default value to allow the binary to be built according to the host where the command
2121
# was called. For example, if we call make docker-build in a local env which has the Apple Silicon M1 SO
2222
# the docker BUILDPLATFORM arg will be linux/arm64 when for Apple x86 it will be linux/amd64. Therefore,
2323
# by leaving it empty we can ensure that the container and binary shipped on it will have the same platform.

docs/book/src/multiversion-tutorial/testdata/project/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ COPY api/ api/
1717
COPY internal/ internal/
1818

1919
# Build
20-
# the GOARCH has not a default value to allow the binary be built according to the host where the command
20+
# the GOARCH has no default value to allow the binary to be built according to the host where the command
2121
# was called. For example, if we call make docker-build in a local env which has the Apple Silicon M1 SO
2222
# the docker BUILDPLATFORM arg will be linux/arm64 when for Apple x86 it will be linux/amd64. Therefore,
2323
# by leaving it empty we can ensure that the container and binary shipped on it will have the same platform.

pkg/plugins/golang/v4/scaffolds/internal/templates/dockerfile.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ COPY api/ api/
5757
COPY internal/ internal/
5858
5959
# Build
60-
# the GOARCH has not a default value to allow the binary be built according to the host where the command
60+
# the GOARCH has no default value to allow the binary to be built according to the host where the command
6161
# was called. For example, if we call make docker-build in a local env which has the Apple Silicon M1 SO
6262
# the docker BUILDPLATFORM arg will be linux/arm64 when for Apple x86 it will be linux/amd64. Therefore,
6363
# by leaving it empty we can ensure that the container and binary shipped on it will have the same platform.

testdata/project-v4-multigroup/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ COPY api/ api/
1717
COPY internal/ internal/
1818

1919
# Build
20-
# the GOARCH has not a default value to allow the binary be built according to the host where the command
20+
# the GOARCH has no default value to allow the binary to be built according to the host where the command
2121
# was called. For example, if we call make docker-build in a local env which has the Apple Silicon M1 SO
2222
# the docker BUILDPLATFORM arg will be linux/arm64 when for Apple x86 it will be linux/amd64. Therefore,
2323
# by leaving it empty we can ensure that the container and binary shipped on it will have the same platform.

testdata/project-v4-with-plugins/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ COPY api/ api/
1717
COPY internal/ internal/
1818

1919
# Build
20-
# the GOARCH has not a default value to allow the binary be built according to the host where the command
20+
# the GOARCH has no default value to allow the binary to be built according to the host where the command
2121
# was called. For example, if we call make docker-build in a local env which has the Apple Silicon M1 SO
2222
# the docker BUILDPLATFORM arg will be linux/arm64 when for Apple x86 it will be linux/amd64. Therefore,
2323
# by leaving it empty we can ensure that the container and binary shipped on it will have the same platform.

testdata/project-v4/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ COPY api/ api/
1717
COPY internal/ internal/
1818

1919
# Build
20-
# the GOARCH has not a default value to allow the binary be built according to the host where the command
20+
# the GOARCH has no default value to allow the binary to be built according to the host where the command
2121
# was called. For example, if we call make docker-build in a local env which has the Apple Silicon M1 SO
2222
# the docker BUILDPLATFORM arg will be linux/arm64 when for Apple x86 it will be linux/amd64. Therefore,
2323
# by leaving it empty we can ensure that the container and binary shipped on it will have the same platform.

0 commit comments

Comments
 (0)