Skip to content

Commit c099e66

Browse files
committed
Fix review findings
1 parent 65740d0 commit c099e66

File tree

6 files changed

+2
-7
lines changed

6 files changed

+2
-7
lines changed

api/bootstrap/kubeadm/v1beta2/kubeadmconfigtemplate_types.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
)
2424

2525
// KubeadmConfigTemplateSpec defines the desired state of KubeadmConfigTemplate.
26-
// +kubebuilder:validation:MinProperties=1
2726
type KubeadmConfigTemplateSpec struct {
2827
// template defines the desired state of KubeadmConfigTemplate.
2928
// +required

api/controlplane/kubeadm/v1beta2/kubeadm_control_plane_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -441,8 +441,8 @@ type KubeadmControlPlaneSpec struct {
441441

442442
// kubeadmConfigSpec is a KubeadmConfigSpec
443443
// to use for initializing and joining machines to the control plane.
444-
// +required
445-
KubeadmConfigSpec bootstrapv1.KubeadmConfigSpec `json:"kubeadmConfigSpec"`
444+
// +optional
445+
KubeadmConfigSpec bootstrapv1.KubeadmConfigSpec `json:"kubeadmConfigSpec,omitempty,omitzero"`
446446

447447
// rolloutBefore is a field to indicate a rollout should be performed
448448
// if the specified criteria is met.

api/controlplane/kubeadm/v1beta2/kubeadmcontrolplanetemplate_types.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import (
2424
)
2525

2626
// KubeadmControlPlaneTemplateSpec defines the desired state of KubeadmControlPlaneTemplate.
27-
// +kubebuilder:validation:MinProperties=1
2827
type KubeadmControlPlaneTemplateSpec struct {
2928
// template defines the desired state of KubeadmControlPlaneTemplate.
3029
// +required

bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigtemplates.yaml

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

controlplane/kubeadm/config/crd/bases/controlplane.cluster.x-k8s.io_kubeadmcontrolplanes.yaml

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

controlplane/kubeadm/config/crd/bases/controlplane.cluster.x-k8s.io_kubeadmcontrolplanetemplates.yaml

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)