Skip to content

Commit 0a2d8df

Browse files
authored
Merge pull request #12632 from k8s-infra-cherrypick-robot/cherry-pick-12616-to-release-1.11
[release-1.11] 🐛 Fix flaky TestReconcileMachinePhases unit test
2 parents 47f6416 + 64d0225 commit 0a2d8df

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

internal/controllers/machine/machine_controller_status_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2166,7 +2166,7 @@ func TestReconcileMachinePhases(t *testing.T) {
21662166

21672167
g.Expect(env.Create(ctx, bootstrapConfig)).To(Succeed())
21682168
g.Expect(env.Create(ctx, infraMachine)).To(Succeed())
2169-
// We have to subtract 2 seconds, because .status.lastUpdated does not contain miliseconds.
2169+
// We have to subtract 2 seconds, because .status.lastUpdated does not contain milliseconds.
21702170
preUpdate := time.Now().Add(-2 * time.Second)
21712171
g.Expect(env.Create(ctx, machine)).To(Succeed())
21722172

@@ -2238,7 +2238,7 @@ func TestReconcileMachinePhases(t *testing.T) {
22382238

22392239
g.Expect(env.Create(ctx, bootstrapConfig)).To(Succeed())
22402240
g.Expect(env.Create(ctx, infraMachine)).To(Succeed())
2241-
// We have to subtract 2 seconds, because .status.lastUpdated does not contain miliseconds.
2241+
// We have to subtract 2 seconds, because .status.lastUpdated does not contain milliseconds.
22422242
preUpdate := time.Now().Add(-2 * time.Second)
22432243
g.Expect(env.Create(ctx, machine)).To(Succeed())
22442244

@@ -2327,7 +2327,7 @@ func TestReconcileMachinePhases(t *testing.T) {
23272327

23282328
g.Expect(env.Create(ctx, bootstrapConfig)).To(Succeed())
23292329
g.Expect(env.Create(ctx, infraMachine)).To(Succeed())
2330-
// We have to subtract 2 seconds, because .status.lastUpdated does not contain miliseconds.
2330+
// We have to subtract 2 seconds, because .status.lastUpdated does not contain milliseconds.
23312331
preUpdate := time.Now().Add(-2 * time.Second)
23322332
g.Expect(env.Create(ctx, machine)).To(Succeed())
23332333

@@ -2405,7 +2405,7 @@ func TestReconcileMachinePhases(t *testing.T) {
24052405

24062406
g.Expect(env.Create(ctx, bootstrapConfig)).To(Succeed())
24072407
g.Expect(env.Create(ctx, infraMachine)).To(Succeed())
2408-
// We have to subtract 2 seconds, because .status.lastUpdated does not contain miliseconds.
2408+
// We have to subtract 2 seconds, because .status.lastUpdated does not contain milliseconds.
24092409
preUpdate := time.Now().Add(-2 * time.Second)
24102410
g.Expect(env.Create(ctx, machine)).To(Succeed())
24112411

@@ -2472,7 +2472,7 @@ func TestReconcileMachinePhases(t *testing.T) {
24722472

24732473
g.Expect(env.Create(ctx, bootstrapConfig)).To(Succeed())
24742474
g.Expect(env.Create(ctx, infraMachine)).To(Succeed())
2475-
// We have to subtract 2 seconds, because .status.lastUpdated does not contain miliseconds.
2475+
// We have to subtract 2 seconds, because .status.lastUpdated does not contain milliseconds.
24762476
preUpdate := time.Now().Add(-2 * time.Second)
24772477
g.Expect(env.Create(ctx, machine)).To(Succeed())
24782478

@@ -2529,7 +2529,7 @@ func TestReconcileMachinePhases(t *testing.T) {
25292529
},
25302530
Spec: corev1.NodeSpec{ProviderID: nodeProviderID},
25312531
}
2532-
g.Expect(env.Create(ctx, node)).To(Succeed())
2532+
g.Expect(env.CreateAndWait(ctx, node)).To(Succeed())
25332533
defer func() {
25342534
g.Expect(env.Cleanup(ctx, node)).To(Succeed())
25352535
}()
@@ -2544,7 +2544,7 @@ func TestReconcileMachinePhases(t *testing.T) {
25442544

25452545
g.Expect(env.Create(ctx, bootstrapConfig)).To(Succeed())
25462546
g.Expect(env.Create(ctx, infraMachine)).To(Succeed())
2547-
// We have to subtract 2 seconds, because .status.lastUpdated does not contain miliseconds.
2547+
// We have to subtract 2 seconds, because .status.lastUpdated does not contain milliseconds.
25482548
preUpdate := time.Now().Add(-2 * time.Second)
25492549
g.Expect(env.Create(ctx, machine)).To(Succeed())
25502550

0 commit comments

Comments
 (0)