Skip to content

Commit a64cb6d

Browse files
committed
avoid duplicate error event
Signed-off-by: jichen <[email protected]>
1 parent ad164b3 commit a64cb6d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/cloud/services/networking/port.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ func (s *Service) GetOrCreatePort(eventObject runtime.Object, clusterName string
179179
if portOpts.Trunk != nil && *portOpts.Trunk {
180180
trunk, err := s.getOrCreateTrunk(eventObject, clusterName, port.Name, port.ID)
181181
if err != nil {
182-
record.Warnf(eventObject, "FailedCreateTrunk", "Failed to create trunk for port %s: %v", portName, err)
183182
return nil, err
184183
}
185184
if err = s.replaceAllAttributesTags(eventObject, trunkResource, trunk.ID, tags); err != nil {

pkg/cloud/services/networking/trunk.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ func (s *Service) getOrCreateTrunk(eventObject runtime.Object, clusterName, trun
5555
PortID: portID,
5656
})
5757
if err != nil {
58+
record.Warnf(eventObject, "FailedCreateTrunk", "Failed to create trunk %s: %w", trunkName, err)
5859
return nil, fmt.Errorf("searching for existing trunk for server: %v", err)
5960
}
6061

@@ -70,7 +71,7 @@ func (s *Service) getOrCreateTrunk(eventObject runtime.Object, clusterName, trun
7071

7172
trunk, err := s.client.CreateTrunk(trunkCreateOpts)
7273
if err != nil {
73-
record.Warnf(eventObject, "FailedCreateTrunk", "Failed to create trunk %s: %v", trunkName, err)
74+
record.Warnf(eventObject, "FailedCreateTrunk", "Failed to create trunk %s: %w", trunkName, err)
7475
return nil, err
7576
}
7677

0 commit comments

Comments
 (0)