WIP - memory optimization #12394
Draft
WIP - memory optimization #12394
+1,502
−3,539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hbelmiro
force-pushed
the
large-objects
branch
4 times, most recently
from
8b394bf to
1e38aff
Compare
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
…est reliability Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
…in client_manager Signed-off-by: Helber Belmiro <[email protected]>
…client_manager Signed-off-by: Helber Belmiro <[email protected]>
…_manager Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
hbelmiro
force-pushed
the
large-objects
branch
from
d45cbc1 to
829bd3b
Compare
…ient` for clarity and consistency Signed-off-by: Helber Belmiro <[email protected]>
…ace`; refactored dependency injection and updated function signatures Signed-off-by: Helber Belmiro <[email protected]>
…Interface`; updated related function signatures, workflows, and tests Signed-off-by: Helber Belmiro <[email protected]>
…PipelineClient`; updated dependency injection, function signatures, and tests Signed-off-by: Helber Belmiro <[email protected]>
…dated dependency injection, function signatures, and tests in affected components Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
|
/retest |
…nt`; updated dependency injection, method signatures, and tests across affected components Signed-off-by: Helber Belmiro <[email protected]>
…rface; updated struct naming, method signatures, and dependencies in `PipelineClientFake` Signed-off-by: Helber Belmiro <[email protected]>
…lowSaver`, `MetricsReporter`, and related components; consolidated `artifact.Client` usage under `PipelineClient` and updated tests Signed-off-by: Helber Belmiro <[email protected]>
…fresh; removed redundant `NewTokenRefresher` comment Signed-off-by: Helber Belmiro <[email protected]>
…r` and `MetricsReporter` tests; updated constructor calls accordingly Signed-off-by: Helber Belmiro <[email protected]>
…initialization for simplicity and clarity Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
Signed-off-by: Helber Belmiro <[email protected]>
hbelmiro
force-pushed
the
large-objects
branch
from
695cd8e to
69eed0d
Compare
…updated all references and imports accordingly Signed-off-by: Helber Belmiro <[email protected]>
…emoved unused import; minor refactor in `FakeBadObjectStore` method signature Signed-off-by: Helber Belmiro <[email protected]>
…om `PipelineClient` struct; updated constructor to reflect changes Signed-off-by: Helber Belmiro <[email protected]>
…ent` for blob storage initialization; added `GetClientSet` method to `KubernetesCoreInterface` Signed-off-by: Helber Belmiro <[email protected]>
hbelmiro
force-pushed
the
large-objects
branch
from
69eed0d to
16081a6
Compare
…ing, optimize response streaming, and remove unused authorization logic Signed-off-by: Helber Belmiro <[email protected]>
…validations; removed redundant comments in `StreamArtifactV1` tests for clarity and conciseness Signed-off-by: Helber Belmiro <[email protected]>
…uring blob storage initialization; consolidated environment configuration and streamlined MinIO bucket setup process Signed-off-by: Helber Belmiro <[email protected]>
…fy logic; removed redundant comments and unused `resolveArtifactPath` wrapper function Signed-off-by: Helber Belmiro <[email protected]>
…removed redundant `Close` call in `SaveFile` method Signed-off-by: Helber Belmiro <[email protected]>
…or improved clarity and conciseness Signed-off-by: Helber Belmiro <[email protected]>
…e clarity in `object_store.go` Signed-off-by: Helber Belmiro <[email protected]>
…n-memory object store for improved simplicity and testability in `BlobObjectStore` Signed-off-by: Helber Belmiro <[email protected]>
hbelmiro
force-pushed
the
large-objects
branch
from
a055bba to
c1e2c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This is a work in progress.
Checklist: