fix: update function signatures and move jose to devDependencies and Delete remote-jwks-cache.ts

Author: Koosha-Owji

lib/__tests__/sdk/utilities/token-utils.spec.ts

@@ -21,7 +21,7 @@ vi.mock('@kinde/jwt-validator', () => ({
 }));
 
 import * as mocks from '../../mocks';
-import { describe, it, expect, beforeAll, afterEach, vi } from 'vitest';
+import { describe, it, expect, beforeAll, afterEach } from 'vitest';
 import {
   type TokenCollection,
   commitTokensToSession,

lib/sdk/clients/browser/authcode-with-pkce.ts

@@ -114,10 +114,7 @@ const createAuthCodeWithPKCEClient = (options: BrowserPKCEClientOptions) => {
     if (!(await isAuthenticated())) {
       throw new Error('Cannot get user details, no authentication credential found');
     }
-    return (await utilities.getUserFromSession(
-      sessionManager,
-      client.tokenValidationDetails
-    ))!;
+    return (await utilities.getUserFromSession(sessionManager))!;
   };
 
   /**
@@ -209,12 +206,7 @@ const createAuthCodeWithPKCEClient = (options: BrowserPKCEClientOptions) => {
       );
     }
 
-    return await tokenClaims.getClaimValue(
-      sessionManager,
-      claim,
-      type,
-      client.tokenValidationDetails
-    );
+    return await tokenClaims.getClaimValue(sessionManager, claim, type);
   };
 
   /**
@@ -233,12 +225,7 @@ const createAuthCodeWithPKCEClient = (options: BrowserPKCEClientOptions) => {
         `Cannot return claim "${claim}", no authentication credential found`
       );
     }
-    return await tokenClaims.getClaim(
-      sessionManager,
-      claim,
-      type,
-      client.tokenValidationDetails
-    );
+    return await tokenClaims.getClaim(sessionManager, claim, type);
   };
 
   /**
@@ -256,11 +243,7 @@ const createAuthCodeWithPKCEClient = (options: BrowserPKCEClientOptions) => {
         `Cannot return permission "${name}", no authentication credential found`
       );
     }
-    return await tokenClaims.getPermission(
-      sessionManager,
-      name,
-      client.tokenValidationDetails
-    );
+    return await tokenClaims.getPermission(sessionManager, name);
   };
 
   /**
@@ -273,10 +256,7 @@ const createAuthCodeWithPKCEClient = (options: BrowserPKCEClientOptions) => {
         'Cannot return user organization, no authentication credential found'
       );
     }
-    return await tokenClaims.getOrganization(
-      sessionManager,
-      client.tokenValidationDetails
-    );
+    return await tokenClaims.getOrganization(sessionManager);
   };
 
   /**
@@ -290,10 +270,7 @@ const createAuthCodeWithPKCEClient = (options: BrowserPKCEClientOptions) => {
         'Cannot return user organizations, no authentication credential found'
       );
     }
-    return await tokenClaims.getUserOrganizations(
-      sessionManager,
-      client.tokenValidationDetails
-    );
+    return await tokenClaims.getUserOrganizations(sessionManager);
   };
 
   /**
@@ -310,10 +287,7 @@ const createAuthCodeWithPKCEClient = (options: BrowserPKCEClientOptions) => {
         'Cannot return user permissions, no authentication credential found'
       );
     }
-    return await tokenClaims.getPermissions(
-      sessionManager,
-      client.tokenValidationDetails
-    );
+    return await tokenClaims.getPermissions(sessionManager);
   };
 
   /**

lib/sdk/clients/server/authorization-code.ts

@@ -139,10 +139,7 @@ const createAuthorizationCodeClient = (
     if (!(await isAuthenticated(sessionManager))) {
       throw new Error('Cannot get user details, no authentication credential found');
     }
-    return (await utilities.getUserFromSession(
-      sessionManager,
-      client.tokenValidationDetails
-    ))!;
+    return (await utilities.getUserFromSession(sessionManager))!;
   };
 
   /**

lib/sdk/clients/server/with-auth-utilities.ts

@@ -110,12 +110,7 @@ const withAuthUtilities = (
       );
     }
 
-    return await tokenClaims.getClaimValue(
-      sessionManager,
-      claim,
-      type,
-      validationDetails
-    );
+    return await tokenClaims.getClaimValue(sessionManager, claim, type);
   };
 
   /**
@@ -136,12 +131,7 @@ const withAuthUtilities = (
         `Cannot return claim "${claim}", no authentication credential found`
       );
     }
-    return await tokenClaims.getClaim(
-      sessionManager,
-      claim,
-      type,
-      validationDetails
-    );
+    return await tokenClaims.getClaim(sessionManager, claim, type);
   };
 
   /**
@@ -161,7 +151,7 @@ const withAuthUtilities = (
         `Cannot return permission "${name}", no authentication credential found`
       );
     }
-    return await tokenClaims.getPermission(sessionManager, name, validationDetails);
+    return await tokenClaims.getPermission(sessionManager, name);
   };
 
   /**
@@ -177,7 +167,7 @@ const withAuthUtilities = (
         'Cannot return user organization, no authentication credential found'
       );
     }
-    return await tokenClaims.getOrganization(sessionManager, validationDetails);
+    return await tokenClaims.getOrganization(sessionManager);
   };
 
   /**
@@ -194,7 +184,7 @@ const withAuthUtilities = (
         'Cannot return user organizations, no authentication credential found'
       );
     }
-    return await tokenClaims.getUserOrganizations(sessionManager, validationDetails);
+    return await tokenClaims.getUserOrganizations(sessionManager);
   };
 
   /**
@@ -214,7 +204,7 @@ const withAuthUtilities = (
         'Cannot return user permissions, no authentication credential found'
       );
     }
-    return await tokenClaims.getPermissions(sessionManager, validationDetails);
+    return await tokenClaims.getPermissions(sessionManager);
   };
 
   /**

lib/sdk/utilities/feature-flags.ts

@@ -29,8 +29,7 @@ export const getFlag = async (
     ((await getClaimValue(
       sessionManager,
       'feature_flags',
-      'access_token',
-      validationDetails
+      'access_token'
     )) as FeatureFlags) ?? {};
   const flag = featureFlags[code];
 

lib/sdk/utilities/remote-jwks-cache.ts

@@ -60,6 +60,7 @@
     "eslint-plugin-prettier": "^5.2.6",
     "eslint-plugin-promise": "^7.2.1",
     "husky": "^8.0.3",
+    "jose": "^6.0.10",
     "jsdom": "^22.0.0",
     "lint-staged": "^13.2.2",
     "ncp": "^2.0.0",
@@ -73,7 +74,6 @@
     "@kinde/jwt-decoder": "^0.2.0",
     "@kinde/jwt-validator": "^0.4.0",
     "@typescript-eslint/parser": "^8.30.1",
-    "jose": "^6.0.10",
     "uncrypto": "^0.1.3"
   },
   "packageManager": "[email protected]+sha512.cdf928fca20832cd59ec53826492b7dc25dc524d4370b6b4adbf65803d32efaa6c1c88147c0ae4e8d579a6c9eec715757b50d4fa35eea179d868eada4ed043af"