Fix generated set trap for proxy cases

Fixes jsdom/jsdom#3565.

Author: domenic

lib/constructs/interface.js

@@ -582,7 +582,7 @@ class Interface {
   generateExport() {
     this.str += `
       exports.is = value => {
-        return utils.isObject(value) && utils.hasOwn(value, implSymbol) && value[implSymbol] instanceof Impl.implementation;
+        return utils.isObject(value) && Object.hasOwn(value, implSymbol) && value[implSymbol] instanceof Impl.implementation;
       };
       exports.isImpl = value => {
         return utils.isObject(value) && value instanceof Impl.implementation;
@@ -666,7 +666,7 @@ class Interface {
         conditions.push(supportsPropertyName(O, P));
       }
       if (overrideBuiltins) {
-        conditions.push(`!utils.hasOwn(${O}, ${P})`);
+        conditions.push(`!Object.hasOwn(${O}, ${P})`);
       } else {
         // TODO: create a named properties object.
         conditions.push(`!(${P} in ${O})`);
@@ -987,33 +987,7 @@ class Interface {
           if (ownDesc === undefined) {
             ownDesc = Reflect.getOwnPropertyDescriptor(target, P);
           }
-          if (ownDesc === undefined) {
-            const parent = Reflect.getPrototypeOf(target);
-            if (parent !== null) {
-              return Reflect.set(parent, P, V, receiver);
-            }
-            ownDesc = { writable: true, enumerable: true, configurable: true, value: undefined };
-          }
-          if (!ownDesc.writable) {
-            return false;
-          }
-          if (!utils.isObject(receiver)) {
-            return false;
-          }
-          const existingDesc = Reflect.getOwnPropertyDescriptor(receiver, P);
-          let valueDesc;
-          if (existingDesc !== undefined) {
-            if (existingDesc.get || existingDesc.set) {
-              return false;
-            }
-            if (!existingDesc.writable) {
-              return false;
-            }
-            valueDesc = { value: V };
-          } else {
-            valueDesc = { writable: true, enumerable: true, configurable: true, value: V };
-          }
-          return Reflect.defineProperty(receiver, P, valueDesc);
+          return utils.ordinarySetWithOwnDescriptor(target, P, V, receiver, ownDesc);
         }
     `;
 
@@ -1065,7 +1039,7 @@ class Interface {
       }
       if (!overrideBuiltins) {
         needFallback = true;
-        this.str += "if (!utils.hasOwn(target, P)) {";
+        this.str += "if (!Object.hasOwn(target, P)) {";
       }
 
       if (!hasNamedSetter) {

lib/output/utils.js

@@ -5,7 +5,7 @@ function isObject(value) {
   return (typeof value === "object" && value !== null) || typeof value === "function";
 }
 
-const hasOwn = Function.prototype.call.bind(Object.prototype.hasOwnProperty);
+const call = Function.call.bind(Function.call);
 
 // Like `Object.assign`, but using `[[GetOwnProperty]]` and `[[DefineOwnProperty]]`
 // instead of `[[Get]]` and `[[Set]]` and only allowing objects
@@ -34,7 +34,7 @@ const ctorRegistrySymbol = Symbol.for("[webidl2js] constructor registry");
 const AsyncIteratorPrototype = Object.getPrototypeOf(Object.getPrototypeOf(async function* () {}).prototype);
 
 function initCtorRegistry(globalObject) {
-  if (hasOwn(globalObject, ctorRegistrySymbol)) {
+  if (Object.hasOwn(globalObject, ctorRegistrySymbol)) {
     return globalObject[ctorRegistrySymbol];
   }
 
@@ -137,6 +137,56 @@ function iteratorResult([key, value], kind) {
   return { value: result, done: false };
 }
 
+function ordinarySetWithOwnDescriptor(target, property, value, receiver, ownDesc) {
+  if (ownDesc === undefined) {
+    const parent = Reflect.getPrototypeOf(target);
+    if (parent !== null) {
+      return Reflect.set(parent, property, value, receiver);
+    }
+    ownDesc = { writable: true, enumerable: true, configurable: true, value: undefined };
+  }
+  if (isDataDescriptor(ownDesc)) {
+    if (!ownDesc.writable) {
+      return false;
+    }
+    if (!isObject(receiver)) {
+      return false;
+    }
+    const existingDesc = Reflect.getOwnPropertyDescriptor(receiver, property);
+    if (existingDesc !== undefined) {
+      if (isAccessorDescriptor(existingDesc)) {
+        return false;
+      }
+      if (existingDesc.writable === false) {
+        return false;
+      }
+      const valueDesc = { value };
+      return Reflect.defineOwnProperty(receiver, property, valueDesc);
+    }
+
+    return Reflect.defineOwnProperty(
+      receiver,
+      property,
+      { value, writable: true, enumerable: true, configurable: true }
+    );
+  }
+
+  const setter = ownDesc.set;
+  if (setter === undefined) {
+    return false;
+  }
+  call(setter, receiver, value);
+  return true;
+}
+
+function isDataDescriptor(desc) {
+  return Object.hasOwn(desc, "value") || Object.hasOwn(desc, "writable");
+}
+
+function isAccessorDescriptor(desc) {
+  return Object.hasOwn(desc, "get") || Object.hasOwn(desc, "set");
+}
+
 const supportsPropertyIndex = Symbol("supports property index");
 const supportedPropertyIndices = Symbol("supported property indices");
 const supportsPropertyName = Symbol("supports property name");
@@ -156,7 +206,6 @@ const asyncIteratorEOI = Symbol("async iterator end of iteration");
 
 module.exports = exports = {
   isObject,
-  hasOwn,
   define,
   newObjectInRealm,
   wrapperSymbol,
@@ -186,5 +235,6 @@ module.exports = exports = {
   asyncIteratorReturn,
   asyncIteratorInit,
   asyncIteratorEOI,
-  iteratorResult
+  iteratorResult,
+  ordinarySetWithOwnDescriptor
 };