Skip to content

Conversation

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Jul 10, 2023

Now that we are running each test 6 times on CI, the risk of flakiness is higher. I want to fix these tests for good but it'l take time, so we're just retrying for now

  • PR Description

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Now that we are running each test 6 times on CI, the risk of flakiness
is higher. I want to fix these tests for good but it'l take time, so
we're just retrying for now
@stefanhaller
Copy link
Collaborator

Ah nice. Sounds good to me!

@jesseduffield jesseduffield merged commit 057742d into master Jul 10, 2023
@jesseduffield jesseduffield deleted the retry-tests-again branch July 10, 2023 12:30
@jesseduffield jesseduffield added the ignore-for-release This will exclude the PR from release notes label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release This will exclude the PR from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants