feat: Use annotated tags if users use GPG

We follow the established hack of rejecting users if they have GPG
enabled, but have not indicated that they will not need to manually
enter their password by setting git.overrideGpg = true.

Should be possible to do, based on the commit implementation.

Author: Chris McDonnell

pkg/commands/git_commands/config.go

@@ -69,6 +69,22 @@ func (self *ConfigCommands) NeedsGpgSubprocessForCommit() bool {
 	return self.gitConfig.GetBool("commit.gpgSign")
 }
 
+// NeedsGpgSubprocessForTag tells us whether the user has gpg enabled for tag actions
+// and needs a subprocess because they have a process where they manually
+// enter their password every time a GPG action is taken
+func (self *ConfigCommands) NeedsGpgSubprocessForTag() bool {
+	overrideGpg := self.UserConfig().Git.OverrideGpg
+	if overrideGpg {
+		return false
+	}
+
+	return self.gitConfig.GetBool("tag.gpgSign")
+}
+
+func (self *ConfigCommands) GetTagGpgSign() bool {
+	return self.gitConfig.GetBool("tag.gpgSign")
+}
+
 func (self *ConfigCommands) GetCoreEditor() string {
 	return self.gitConfig.Get("core.editor")
 }

pkg/gui/controllers/helpers/tags_helper.go

@@ -1,6 +1,8 @@
 package helpers
 
 import (
+	"errors"
+
 	"github.com/jesseduffield/gocui"
 	"github.com/jesseduffield/lazygit/pkg/gui/context"
 	"github.com/jesseduffield/lazygit/pkg/gui/types"
@@ -22,7 +24,11 @@ func NewTagsHelper(c *HelperCommon, commitsHelper *CommitsHelper) *TagsHelper {
 func (self *TagsHelper) OpenCreateTagPrompt(ref string, onCreate func()) error {
 	doCreateTag := func(tagName string, description string, force bool) error {
 		return self.c.WithWaitingStatus(self.c.Tr.CreatingTag, func(gocui.Task) error {
-			if description != "" {
+			if self.c.Git().Config.NeedsGpgSubprocessForTag() {
+				return errors.New(self.c.Tr.DisabledForGPG)
+			}
+			// We must create an annotated tag when users use GPG, even if the message is empty
+			if description != "" || self.c.Git().Config.GetTagGpgSign() {
 				self.c.LogAction(self.c.Tr.Actions.CreateAnnotatedTag)
 				if err := self.c.Git().Tag.CreateAnnotated(tagName, ref, description, force); err != nil {
 					return err