Add option to customize the variable for session token #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlejo
changed the title
|
Do you have any news about this PR? |
Vlatombe
reviewed
Feb 23, 2022
...n/java/com/cloudbees/jenkins/plugins/awscredentials/AmazonWebServicesCredentialsBinding.java
Show resolved
Hide resolved
Vlatombe
reviewed
Feb 23, 2022
...n/java/com/cloudbees/jenkins/plugins/awscredentials/AmazonWebServicesCredentialsBinding.java
Outdated
Show resolved
Hide resolved
|
@Vlatombe Can this be merged ? |
|
@olamy Any idea why this was not merged? If we resolved the conflicts, could we get this reviewed and merged? Without this change, we cannot use two credentials at the same time due to the overlapping AWS_SESSION_TOKEN variables. |
|
@smccarthy-godaddy @dclayton-godaddy Unfortunately there aren't as many active maintainers of this plugin as there used to be. We don't want your pull request to be in limbo forever; you can step forward to become a maintainer of this plugin following the instructions here: https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/ |
|
@dclayton-godaddy sure if you resolve conflicts, this can reviewed and merged |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as: #74
for #90