Skip to content

Commit 0f85cae

Browse files
authored
Merge pull request #441 from ankitskvmdam/patch-1
fix: fillNa throws an error when values is an empty string
2 parents 2c274ee + 9b20ffa commit 0f85cae

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/danfojs-base/core/frame.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2102,7 +2102,7 @@ export default class DataFrame extends NDframe implements DataFrameInterface {
21022102
): DataFrame | void {
21032103
let { columns, inplace } = { inplace: false, ...options }
21042104

2105-
if (!values && typeof values !== "boolean" && typeof values !== "number") {
2105+
if (!values && typeof values !== "boolean" && typeof values !== "number" && typeof values !== "string") {
21062106
throw Error('ParamError: value must be specified');
21072107
}
21082108

0 commit comments

Comments
 (0)