From cc2c606d2ecb39b46c13353c1a619e508c4d2bd3 Mon Sep 17 00:00:00 2001 From: Stephen Gold Date: Mon, 3 Jan 2022 15:10:57 -0800 Subject: [PATCH 1/2] ALAudioRenderer: update direct-filter ID even when filter is up-to-date --- .../jme3/audio/openal/ALAudioRenderer.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/jme3-core/src/main/java/com/jme3/audio/openal/ALAudioRenderer.java b/jme3-core/src/main/java/com/jme3/audio/openal/ALAudioRenderer.java index 80c8142bd2..0710500b83 100644 --- a/jme3-core/src/main/java/com/jme3/audio/openal/ALAudioRenderer.java +++ b/jme3-core/src/main/java/com/jme3/audio/openal/ALAudioRenderer.java @@ -503,18 +503,18 @@ public void updateSourceParam(AudioSource src, AudioParam param) { if (!supportEfx) { return; } - - if (src.getDryFilter() != null) { - Filter f = src.getDryFilter(); - if (f.isUpdateNeeded()) { - updateFilter(f); - - // NOTE: must re-attach filter for changes to apply. - al.alSourcei(id, EFX.AL_DIRECT_FILTER, f.getId()); - } + Filter dryFilter = src.getDryFilter(); + int filterId; + if (dryFilter == null) { + filterId = EFX.AL_FILTER_NULL; } else { - al.alSourcei(id, EFX.AL_DIRECT_FILTER, EFX.AL_FILTER_NULL); + if (dryFilter.isUpdateNeeded()) { + updateFilter(dryFilter); + } + filterId = dryFilter.getId(); } + // NOTE: must re-attach filter for changes to apply. + al.alSourcei(id, EFX.AL_DIRECT_FILTER, filterId); break; case Looping: if (src.isLooping() && !(src.getAudioData() instanceof AudioStream)) { From 60420503049bec95825e83427740bf2bee6e7311 Mon Sep 17 00:00:00 2001 From: Stephen Gold Date: Mon, 3 Jan 2022 22:23:15 -0800 Subject: [PATCH 2/2] ALAudioRenderer: update the copyright dates --- .../src/main/java/com/jme3/audio/openal/ALAudioRenderer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jme3-core/src/main/java/com/jme3/audio/openal/ALAudioRenderer.java b/jme3-core/src/main/java/com/jme3/audio/openal/ALAudioRenderer.java index 0710500b83..29ce483aca 100644 --- a/jme3-core/src/main/java/com/jme3/audio/openal/ALAudioRenderer.java +++ b/jme3-core/src/main/java/com/jme3/audio/openal/ALAudioRenderer.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009-2021 jMonkeyEngine + * Copyright (c) 2009-2022 jMonkeyEngine * All rights reserved. * * Redistribution and use in source and binary forms, with or without