solve issue #1542 (crash in TestAppStates) #1545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stephengold
added
the
bug
stephengold
added a commit
that referenced
this pull request
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several things were broken here.
It was inappropriate for
TestAppStatesto use a default screen controller with "HelloJme.xml", because of course that screen controller does not implement the "quit()" method referenced in "HelloJme.xml". Also, "HelloJme.xml" specifies that the controller for its "start" screen should be an instance ofTestNiftyGui. Furthermore, the "end" screen of "HelloJme.xml" is empty and therefore useless.In order for
TestAppStatesandTestNiftyGuito cleanly share "HelloJme.xml", I added a classStartScreenControllerto serve as a screen controller for both apps.I also deleted the "end" screen and re-purposed
quit()to cleanly terminate the application.