Skip to content

Commit 64e38a0

Browse files
authored
more precise return types for 13 clone() methods (#1683)
1 parent dcdece2 commit 64e38a0

File tree

12 files changed

+16
-16
lines changed

12 files changed

+16
-16
lines changed

jme3-core/src/main/java/com/jme3/animation/AudioTrack.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ public float[] getKeyFrameTimes() {
165165
* @return a new track
166166
*/
167167
@Override
168-
public Track clone() {
168+
public AudioTrack clone() {
169169
return new AudioTrack(audio, length, startOffset);
170170
}
171171

jme3-core/src/main/java/com/jme3/animation/CompactArray.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ public final T[] toObjectArray() {
268268
* @throws CloneNotSupportedException never
269269
*/
270270
@Override
271-
public Object clone() throws CloneNotSupportedException {
271+
public CompactArray clone() throws CloneNotSupportedException {
272272
return Cloner.deepClone(this);
273273
}
274274

jme3-core/src/main/java/com/jme3/animation/EffectTrack.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ public float[] getKeyFrameTimes() {
250250
* @return a new instance
251251
*/
252252
@Override
253-
public Track clone() {
253+
public EffectTrack clone() {
254254
return new EffectTrack(emitter, length, startOffset);
255255
}
256256

jme3-core/src/main/java/com/jme3/asset/CloneableSmartAsset.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public interface CloneableSmartAsset extends Cloneable {
6262
* @return A clone of this asset.
6363
* The cloned asset cannot reference equal this asset.
6464
*/
65-
public Object clone();
65+
public CloneableSmartAsset clone();
6666

6767
/**
6868
* Set by the {@link AssetManager} to track this asset.

jme3-core/src/main/java/com/jme3/effect/influencers/DefaultParticleInfluencer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public void read(JmeImporter im) throws IOException {
100100
}
101101

102102
@Override
103-
public ParticleInfluencer clone() {
103+
public DefaultParticleInfluencer clone() {
104104
try {
105105
DefaultParticleInfluencer clone = (DefaultParticleInfluencer) super.clone();
106106
clone.initialVelocity = initialVelocity.clone();

jme3-core/src/main/java/com/jme3/effect/influencers/EmptyParticleInfluencer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@ public float getVelocityVariation() {
7777
}
7878

7979
@Override
80-
public ParticleInfluencer clone() {
80+
public EmptyParticleInfluencer clone() {
8181
try {
82-
return (ParticleInfluencer) super.clone();
82+
return (EmptyParticleInfluencer) super.clone();
8383
} catch (CloneNotSupportedException e) {
8484
throw new AssertionError();
8585
}

jme3-core/src/main/java/com/jme3/effect/influencers/NewtonianParticleInfluencer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ protected void applyVelocityVariation(Particle particle) {
143143
}
144144

145145
@Override
146-
public ParticleInfluencer clone() {
146+
public NewtonianParticleInfluencer clone() {
147147
NewtonianParticleInfluencer result = new NewtonianParticleInfluencer();
148148
result.normalVelocity = normalVelocity;
149149
result.initialVelocity = initialVelocity;

jme3-core/src/main/java/com/jme3/scene/instancing/InstancedNode.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -326,12 +326,12 @@ public void instance() {
326326
}
327327

328328
@Override
329-
public Node clone() {
329+
public InstancedNode clone() {
330330
return clone(true);
331331
}
332332

333333
@Override
334-
public Node clone(boolean cloneMaterials) {
334+
public InstancedNode clone(boolean cloneMaterials) {
335335
InstancedNode clone = (InstancedNode)super.clone(cloneMaterials);
336336

337337
if (instancesMap.size() > 0) {

jme3-examples/src/main/java/jme3test/asset/TestAssetCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ private static class DummyData implements CloneableSmartAsset {
5959
private byte[] data = new byte[10 * 1024];
6060

6161
@Override
62-
public Object clone(){
62+
public DummyData clone(){
6363
try {
6464
DummyData clone = (DummyData) super.clone();
6565
clone.data = data.clone();

jme3-plugins/src/main/java/com/jme3/scene/plugins/IrBoneWeightIndex.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ public IrBoneWeightIndex(int boneIndex, float boneWeight) {
4242
}
4343

4444
@Override
45-
public Object clone() {
45+
public IrBoneWeightIndex clone() {
4646
try {
47-
return super.clone();
47+
return (IrBoneWeightIndex)super.clone();
4848
} catch (CloneNotSupportedException ex) {
4949
throw new AssertionError(ex);
5050
}

0 commit comments

Comments
 (0)