Skip to content
This repository was archived by the owner on Dec 6, 2022. It is now read-only.

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Aug 4, 2020

Accepts and emits Uint8Arrays instead of node Buffers but converts
them internally because bitcoinjs-lib only understands Buffers.

BREAKING CHANGE:

  • util.cid returns v1 CIDs

Accepts and emits `Uint8Array`s instead of node `Buffer`s but converts
them internally because `bitcoinjs-lib` only understands `Buffer`s.

BREAKING CHANGE:

- `util.serialize` returns `Uint8Array`s
@achingbrain achingbrain requested a review from vmx August 4, 2020 12:58
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           67        69    +2     
=========================================
+ Hits            67        69    +2     
Impacted Files Coverage Δ
src/resolver.js 100.00% <100.00%> (ø)
src/util.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9d6f3...1adb169. Read the comment docs.

@vmx vmx merged commit f9d3c7e into master Aug 4, 2020
@vmx vmx deleted the fix/replace-node-buffers-with-uint8array branch August 4, 2020 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants