chore: do not call shutdown twice

Alan Shaw · web-flow · commit b37ebcc74520 · 2019-12-03T10:49:57.000Z
The interface tests in ipfs-inactive/js-ipfs-http-client#1183 have started throwing `UnhandledPromiseRejection`s for a connection refused error to `/api/v0/shutdown`. This is because `stop` was being called and then called again in `killProcess`. With callbacks this error was smothered but it is now appearing with the promise-only API.
diff --git a/src/ipfsd-daemon.js b/src/ipfsd-daemon.js
@@ -251,8 +251,7 @@ class Daemon {
     if (!this.subprocess) {
       return this
     }
-    await this.api.stop()
-    // TODO this should call this.api.stop
+
     await this.killProcess(timeout)
 
     if (this.disposable) {

Original file line number	Diff line number	Diff line change
`@@ -251,8 +251,7 @@ class Daemon {`
`251`	`251`	`if (!this.subprocess) {`
`252`	`252`	`return this`
`253`	`253`	`}`
`254`		`- await this.api.stop()`
`255`		`- // TODO this should call this.api.stop`
	`254`	`+`
`256`	`255`	`await this.killProcess(timeout)`
`257`	`256`
`258`	`257`	`if (this.disposable) {`