This repository was archived by the owner on Sep 28, 2021. It is now read-only.
chore: convert to async await syntax #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
suggested changes
Oct 7, 2019
Member
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
It looks good to me! Just asked minor things to get this to the finish line
src/utils/p-try-each.js
Outdated
| @@ -0,0 +1,25 @@ | |||
| 'use strict' | |||
|
|
|||
| const pTryEeach = async (iterable) => { | |||
Member
There was a problem hiding this comment.
Can you create a module for this?
Contributor
Author
There was a problem hiding this comment.
Yes, I can and I will. Can we merge this as it is and then update it later to use the module that I'll create?
Member
There was a problem hiding this comment.
you have a typo in the fn name pTryEeachshould be pTryEach
hugomrdias
suggested changes
Oct 7, 2019
src/utils/p-try-each.js
Outdated
| @@ -0,0 +1,25 @@ | |||
| 'use strict' | |||
|
|
|||
| const pTryEeach = async (iterable) => { | |||
Member
There was a problem hiding this comment.
you have a typo in the fn name pTryEeachshould be pTryEach
PedroMiguelSS
force-pushed
the
chore/convert-to-async-await-syntax
branch
from
61e7445 to
e4e672c
Compare
hugomrdias
approved these changes
Oct 7, 2019
vasco-santos
approved these changes
Oct 14, 2019
vasco-santos
added a commit
that referenced
this pull request
Oct 14, 2019
BREAKING CHANGE: All places in the API that used callbacks are now replaced with async/await Co-authored-by: PedroMiguelSS <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts this module's both exported
getResponseandresolverfunctions to async/await syntax.It also adds a util file called
p-try-eachthat mimics the sameasync/tryEachmethod.Closes #27.