Skip to content

Commit 898a962

Browse files
chore: update dependency to Android native lib (#46)
* chore: update dependency to Android native lib * fix: don't use release token for `basic-tests` workflow * fix: make release token not mandatory in build, lint, and setup workflows
1 parent 692b0ce commit 898a962

File tree

5 files changed

+8
-14
lines changed

5 files changed

+8
-14
lines changed

.github/workflows/basic-tests.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,11 @@ on:
99
jobs:
1010
setup:
1111
uses: ./.github/workflows/reusable_setup.yml
12-
secrets:
13-
THE_GH_RELEASE_TOKEN: ${{ secrets.CAP_GH_RELEASE_TOKEN }}
1412

1513
lint-test:
1614
needs: 'setup'
1715
uses: ./.github/workflows/reusable_lint.yml
18-
secrets:
19-
THE_GH_RELEASE_TOKEN: ${{ secrets.CAP_GH_RELEASE_TOKEN }}
2016

2117
build-packages:
2218
needs: 'setup'
23-
uses: ./.github/workflows/reusable_build.yml
24-
secrets:
25-
THE_GH_RELEASE_TOKEN: ${{ secrets.CAP_GH_RELEASE_TOKEN }}
19+
uses: ./.github/workflows/reusable_build.yml

.github/workflows/reusable_build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
workflow_call:
55
secrets:
66
THE_GH_RELEASE_TOKEN:
7-
required: true
7+
required: false
88

99
jobs:
1010
build:
@@ -14,7 +14,7 @@ jobs:
1414
- uses: actions/checkout@v4
1515
with:
1616
fetch-depth: 0
17-
token: ${{ secrets.THE_GH_RELEASE_TOKEN }}
17+
token: ${{ secrets.THE_GH_RELEASE_TOKEN || github.token }}
1818

1919
- name: 'Setup Tools'
2020
uses: ./.github/actions/setup-tools

.github/workflows/reusable_lint.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
workflow_call:
55
secrets:
66
THE_GH_RELEASE_TOKEN:
7-
required: true
7+
required: false
88

99
jobs:
1010
lint:
@@ -14,7 +14,7 @@ jobs:
1414
- uses: actions/checkout@v4
1515
with:
1616
fetch-depth: 0
17-
token: ${{ secrets.THE_GH_RELEASE_TOKEN }}
17+
token: ${{ secrets.THE_GH_RELEASE_TOKEN || github.token }}
1818

1919
- name: 'Setup Tools'
2020
uses: ./.github/actions/setup-tools

.github/workflows/reusable_setup.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
workflow_call:
55
secrets:
66
THE_GH_RELEASE_TOKEN:
7-
required: true
7+
required: false
88

99
jobs:
1010
setup:
@@ -17,7 +17,7 @@ jobs:
1717
- uses: actions/checkout@v4
1818
with:
1919
fetch-depth: 0
20-
token: ${{ secrets.THE_GH_RELEASE_TOKEN }}
20+
token: ${{ secrets.THE_GH_RELEASE_TOKEN || github.token }}
2121

2222
- name: 'Setup Tools'
2323
uses: ./.github/actions/setup-tools

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ repositories {
5858
dependencies {
5959
// implementation fileTree(dir: 'libs', include: ['*.jar'])
6060
implementation project(':capacitor-android')
61-
implementation "com.capacitorjs:osinappbrowser-android:1.2.1"
61+
implementation "io.ionic.libs:ioninappbrowser-android:1.2.1"
6262
implementation 'androidx.browser:browser:1.8.0'
6363
implementation "androidx.constraintlayout:constraintlayout:2.2.0"
6464
implementation "androidx.appcompat:appcompat:$androidxAppCompatVersion"

0 commit comments

Comments
 (0)