Suggested added

Author: hsyrja

cmd/gpu_fakedev/gpu_fakedev.go

@@ -59,9 +59,10 @@ const (
 	devfsPath  = "dev"
 	mib        = 1024.0 * 1024.0
 	// null device major, minor on linux.
-	devNullMajor    = 1
-	devNullMinor    = 3
-	devNullType     = unix.S_IFCHR
+	devNullMajor = 1
+	devNullMinor = 3
+	devNullType  = unix.S_IFCHR
+	// GPU connectivity
 	maxK8sLabelSize = 63
 	fullyConnected  = "FULL"
 )
@@ -299,29 +300,20 @@ func generateDriFiles(opts genOptions) {
 func makeXelinkSideCar(topology string, gpus, tiles int, connections string) {
 	if topology != fullyConnected {
 		log.Printf("XELINK: generate xelink sidecar label file, using (GPUs: %d, Tiles: %d)", gpus, tiles)
+		saveSideCarFile(connections)
 	} else {
 		log.Printf("XELINK: generate xelink sidecar label file, using (GPUs: %d, Tiles: %d, Topology: %s)", gpus, tiles, topology)
-	}
-
-	if topology == fullyConnected {
 		saveSideCarFile(buildConnectionList(gpus, tiles))
-	} else {
-		saveSideCarFile(connections)
 	}
 }
 
 func buildConnectionList(gpus, tiles int) string {
-	mm := 0
-
 	var nodes = make([]string, 0)
 
-	for mm < gpus {
-		nn := 0
-		for nn < tiles {
+	for mm := 0; mm < gpus; mm++ {
+		for nn := 0; nn < tiles; nn++ {
 			nodes = append(nodes, fmt.Sprintf("%d.%d", mm, nn))
-			nn++
 		}
-		mm++
 	}
 
 	var links = make(map[string]struct{}, 0)