gpu: do not fail if device scanning fails

Graham Whaley · Graham Whaley · commit 6537e38499a5 · 2020-01-29T09:24:50.000Z
If we fail to scan for GPU devices (note, that is potentially different from not finding any devices during a scan), then warn on it, and go around the poll loop again. Do not treat it as a fatal error or we might end up in a re-launch death deploy loop... Of course, getting a warning in your logs every 5s could also be annoying, but is somewhat 'less fatal'. Fixes: #260 Fixes: #230 Signed-off-by: Graham Whaley <graham.whaley@intel.com>
diff --git a/cmd/gpu_plugin/gpu_plugin.go b/cmd/gpu_plugin/gpu_plugin.go
@@ -68,7 +68,7 @@ func (dp *devicePlugin) Scan(notifier dpapi.Notifier) error {
 	for {
 		devTree, err := dp.scan()
 		if err != nil {
-			return err
+			fmt.Println("WARNING: Failed to scan: ", err)
 		}
 
 		notifier.Notify(devTree)

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ func (dp *devicePlugin) Scan(notifier dpapi.Notifier) error {`
`68`	`68`	`for {`
`69`	`69`	`devTree, err := dp.scan()`
`70`	`70`	`if err != nil {`
`71`		`- return err`
	`71`	`+ fmt.Println("WARNING: Failed to scan: ", err)`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`notifier.Notify(devTree)`