[CAD-402] Adding changes to the trace events we need and removing time from them #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
suggested changes
Jan 9, 2020
mrBliss
reviewed
Jan 9, 2020
mrBliss
reviewed
Jan 9, 2020
| withTxs = withSyncState mempool (TxsForBlockInSlot currentSlot) | ||
|
|
||
| trace $ TraceForgeAboutToLead currentSlot | ||
|
|
There was a problem hiding this comment.
Nitpicking: can you remove this newly added blank line?
mrBliss
approved these changes
Jan 9, 2020
mrBliss
force-pushed
the
ksaric/CAD-402
branch
from
7672879 to
e358311
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 10, 2020
1432: [CAD-402] Adding changes to the trace events we need and removing time from them r=mrBliss a=ksaric https://jira.iohk.io/browse/CAD-402 Let me just copy the description from there: ``` The current issue (https://jira.iohk.io/browse/CAD-314) was measuring too much. We need to start the micro benchmarking from small and precise steps, the opposite that I started with. A good initial microbenchmark would be the time it takes for the block to be forged during the slot the leader is producing a block. ``` Co-authored-by: ksaric <[email protected]>
coot
pushed a commit
that referenced
this pull request
May 16, 2022
1432: [CAD-402] Adding changes to the trace events we need and removing time from them r=mrBliss a=ksaric https://jira.iohk.io/browse/CAD-402 Let me just copy the description from there: ``` The current issue (https://jira.iohk.io/browse/CAD-314) was measuring too much. We need to start the micro benchmarking from small and precise steps, the opposite that I started with. A good initial microbenchmark would be the time it takes for the block to be forged during the slot the leader is producing a block. ``` Co-authored-by: ksaric <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.iohk.io/browse/CAD-402
Let me just copy the description from there: