C# 6 String interpolation #1012
Conversation
…ts use string literals, nested string literals are not allowed.
| case "System.String.Format": | ||
| if (context.Settings.StringInterpolation && arguments.Length > 1 | ||
| && arguments[0] is PrimitiveExpression stringExpression && stringExpression.Value is string | ||
| && arguments.Skip(1).All(a => !a.DescendantsAndSelf.OfType<PrimitiveExpression>().Any(p => p.Value is string))) |
There was a problem hiding this comment.
You only check for normal string literals.
Formatted string literals are probably also forbidden?
What about char literals?
What about the ?: operator (might be problematic due to having a :)?
There was a problem hiding this comment.
I just tested with char literals and interpolated strings... seems fine to use them.
As for conditional expressions: seems they're only valid when wrapped in parentheses.
|
@siegfriedpammer you might want to: git branch backup
git checkout master
git branch -D string-interpolation
git branch string-interpolation
git checkout string-interpolation
git cherry-pick backupto try to fix the merge conflicts, update to latest head of master and then you cherry pick all your commits from her copied to |
…olation literals.
…erpolation # Conflicts: # ICSharpCode.Decompiler.Tests/ICSharpCode.Decompiler.Tests.csproj
siegfriedpammer
force-pushed
the
string-interpolation
branch
from
9e95568 to
fdb1991
Compare
No description provided.