Skip to content

Commit 2c897b5

Browse files
committed
Revert "refactor(fund): change to loop."
This reverts commit a567031. Signed-off-by: Sophia Koehler <[email protected]>
1 parent b6959e6 commit 2c897b5

File tree

2 files changed

+30
-37
lines changed

2 files changed

+30
-37
lines changed

channel/funder.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
package channel
1616

1717
import (
18-
"bytes"
1918
"context"
2019
"fmt"
2120
"math/big"
@@ -42,25 +41,13 @@ import (
4241
perror "polycry.pt/poly-go/errors"
4342
)
4443

45-
// LogCapturer is a custom logger that captures log messages.
46-
type LogCapturer struct {
47-
capturedLogs *bytes.Buffer
48-
}
49-
5044
type assetHolder struct {
5145
*assetholder.Assetholder
5246
*common.Address
5347
contract *bind.BoundContract
5448
assetIndex channel.Index
5549
}
5650

57-
// NewLogCapturer creates a new LogCapturer instance.
58-
func NewLogCapturer() *LogCapturer {
59-
return &LogCapturer{
60-
capturedLogs: new(bytes.Buffer),
61-
}
62-
}
63-
6451
// Funder implements the channel.Funder interface for Ethereum.
6552
//
6653
// In addition to the `Fund` method required by the `Funder` interface, it also
@@ -198,7 +185,6 @@ func (f *Funder) Fund(ctx context.Context, request channel.FundingReq) error {
198185
if channel.IsAssetFundingError(err) && err != nil {
199186
fundingErr, ok := err.(*channel.AssetFundingError)
200187
if !ok {
201-
fmt.Println(err)
202188
return fmt.Errorf("wrong type: expected %T, got %T", &channel.AssetFundingError{}, err)
203189
}
204190
fundingErrs = append(fundingErrs, fundingErr)
@@ -424,7 +410,6 @@ loop:
424410
select {
425411
case rawEvent := <-deposited:
426412
event, ok := rawEvent.Data.(*assetholder.AssetholderDeposited)
427-
fmt.Println("Funding Event ", event)
428413
if !ok {
429414
log.Panic("wrong event type")
430415
}

channel/test/fund.go

Lines changed: 30 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -36,30 +36,38 @@ func FundAll(ctx context.Context, funders []*channel.Funder, reqs []*pchannel.Fu
3636
var mutex sync.Mutex
3737

3838
var wg sync.WaitGroup
39-
wg.Add(len(funders))
39+
wg.Add(2)
4040

41-
waitTime := 2 * time.Second
41+
go func() {
42+
defer wg.Done()
43+
startTime := time.Now()
44+
err := funders[egoisticIndex].Fund(ctx, *reqs[egoisticIndex])
45+
require.NoError(t, err)
46+
finishTime := time.Now()
47+
require.NoError(t, err)
48+
mutex.Lock()
49+
finishTimes[egoisticIndex] = FunderFinishTime{
50+
Index: egoisticIndex,
51+
Time: finishTime.Sub(startTime),
52+
}
53+
mutex.Unlock()
54+
}()
4255

43-
for i := range funders {
44-
i := i
45-
go func() {
46-
defer wg.Done()
47-
if i != egoisticIndex {
48-
time.Sleep(waitTime)
49-
}
50-
startTime := time.Now()
51-
err := funders[i].Fund(ctx, *reqs[i])
52-
require.NoError(t, err)
53-
finishTime := time.Now()
54-
mutex.Lock()
55-
finishTimes[i] = FunderFinishTime{
56-
Index: i,
57-
Time: finishTime.Sub(startTime),
58-
}
59-
mutex.Unlock()
60-
}()
61-
62-
}
56+
go func() {
57+
defer wg.Done()
58+
time.Sleep(2 * time.Second)
59+
startTime := time.Now()
60+
err := funders[1-egoisticIndex].Fund(ctx, *reqs[1-egoisticIndex])
61+
require.NoError(t, err)
62+
finishTime := time.Now()
63+
require.NoError(t, err)
64+
mutex.Lock()
65+
finishTimes[1-egoisticIndex] = FunderFinishTime{
66+
Index: 1 - egoisticIndex,
67+
Time: finishTime.Sub(startTime),
68+
}
69+
mutex.Unlock()
70+
}()
6371

6472
wg.Wait()
6573
return finishTimes, nil

0 commit comments

Comments
 (0)