Do not hang when deciding not to compress a file upload #1613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command would hang forever: ```console $ echo test > test.txt $ http -x httpbin.org/post @test.txt ``` HTTPie would read the file, compress it, then discard the compressed data because it's larger than the original. This made `request.body` an exhausted file handle, which `requests` doesn't seem to like.
blyxxyz
force-pushed
the
incompressible-upload
branch
from
26a3903 to
301f316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command would hang forever:
HTTPie would read the file, compress it, then discard the compressed data because it's larger than the original. This made
request.bodyan exhausted file handle, whichrequestsdoesn't seem to like.(Maybe it would be better in this case to do unconditional streaming compression to avoid buffering large files. We might do that in xh. But that would be a bigger change.)