[WIP] Metaprogramming interface to tactics #524
Conversation
| ) | ||
| Right mp -> ([], Just mp) | ||
| define $ \GetMetaprogramCache _ -> do | ||
| files <- liftIO getKnownFiles |
There was a problem hiding this comment.
GetMetaprogramCache won't be recomputed when the result of getKnownFiles changes.
Also, there's already a function called getKnownFiles in ghcide, you should rename it to avoid confusion.
There was a problem hiding this comment.
Good catch. What's the right way to discover new files in shake?
There was a problem hiding this comment.
Create an early cutoff rule for getKnownFiles, and use alwaysRerun.
There was a problem hiding this comment.
Although that might not be such a good idea, since it would call ls every time a codeaction is generated, right?
There was a problem hiding this comment.
I guess you need to register a file watcher with the client, like we were discussing earlier on IRC.
pepeiborra
force-pushed
the
master
branch
2 times, most recently
from
66ada8c to
d4f5d43
Compare
|
@isovector Is this PR still relevant? If not, could you close this PR? |
|
@Ailrun yes, it's still relevant. |
4 participants
This PR introduces a tactic metaprogramming language for creating new code actions and extending
Attempt to fill hole. It will automatically find scripts under$XDG_CONFIG_HOME/hls-tactics-pluginand load them into the tactics plugin.