Support fourmolu 0.13 #3662
Merged
Support fourmolu 0.13 #3662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonchinn178
commented
Jun 15, 2023
| [ goldenWithFourmolu cli "formats correctly" "Fourmolu" "formatted" $ \doc -> do | ||
| formatDoc doc (FormattingOptions 4 True Nothing Nothing Nothing) | ||
| , goldenWithFourmolu cli "formats imports correctly" "Fourmolu" "formatted" $ \doc -> do | ||
| , goldenWithFourmolu cli "formats imports correctly" "Fourmolu2" "formatted" $ \doc -> do |
Contributor
Author
There was a problem hiding this comment.
This seems to have been testing the wrong file for quite a while:
f653555#diff-5e783ba6072f1ca27c7171a3ece5043ea46f212e57f68272b52ecc36a8152d59L26-L36
georgefst
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the revert from #3661. Feel free to merge into one PR. cc @joyfulmantis
Tested with the following script:
( set -e function test_fourmolu() { local constraint="fourmolu$1" echo "#### $constraint" cabal test \ -w "$2" \ --constraint "$constraint" \ --index-state HEAD \ hls-fourmolu-plugin } test_fourmolu '==0.13.0.0' 'ghc-9.6.1' test_fourmolu '<0.13' 'ghc-9.6.1' test_fourmolu '<0.8.1' 'ghc-9.2.7' test_fourmolu '<0.7' 'ghc-9.2.7' )Note: I noticed the tests sometimes flakily fail with
Not sure what's happening, and why the test directory is repeated.