Enable plugin tests in CI for GHC 9.4 #3420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
requested review from
Ailrun,
Anton-Latukha,
July541,
OliverMadine,
VeryMilkyJoe,
berberman,
drsooch,
eddiemundo,
fendor,
georgefst,
isovector,
kokobd,
konn,
ozkutuk,
pepeiborra,
santiweight and
uhbif19
as code owners
wz1000
force-pushed
the
wip/fix-9.4-tests
branch
3 times, most recently
from
08a16e5 to
bacbd40
Compare
pepeiborra
approved these changes
Dec 21, 2022
Collaborator
pepeiborra
left a comment
pepeiborra
left a comment
There was a problem hiding this comment.
Thanks for noticing this!
wz1000
force-pushed
the
wip/fix-9.4-tests
branch
2 times, most recently
from
b792d64 to
f6019b3
Compare
Collaborator
|
Oof, good catch! |
Contributor
|
Good work Zubin. |
wz1000
force-pushed
the
wip/fix-9.4-tests
branch
from
4413617 to
1925ff0
Compare
wz1000
force-pushed
the
wip/fix-9.4-tests
branch
from
1925ff0 to
578bc3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We neglected to enable testing in CI of all the newly patched plugins for GHC 9.4