Unify showSDocUnsafe #2830
Merged
Unify showSDocUnsafe #2830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
July541
requested review from
Ailrun,
berberman,
eddiemundo,
isovector and
pepeiborra
as code owners
michaelpj
reviewed
Apr 18, 2022
Collaborator
michaelpj
left a comment
michaelpj
left a comment
There was a problem hiding this comment.
Wonderful, thank you!
Collaborator
|
lgtm, thanks! |
Ailrun
approved these changes
Apr 20, 2022
eddiemundo
approved these changes
Apr 21, 2022
Collaborator
eddiemundo
left a comment
eddiemundo
left a comment
There was a problem hiding this comment.
I wanna bikeshed printOutputable to prettyPrintAsText since it's the same as prettyPrint, or oppositely prettyPrint to printOutputableAsString, but since you already did a change once, it's fine...
So all good.
Collaborator
|
Temporarily taking out of the merge queue until the release is done. |
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this pull request
May 21, 2022
* Unify showSDocUnsafe * Fix dependency * Add missing instance * Add missing instance * Remove unused imports * Clean up unused code * Remove unnecessary exports & Rename * Unify use printOutputable * Remove redundant import * Replace show with unpack * Rerun tests * Rerun tests Co-authored-by: Pepe Iborra <[email protected]> Co-authored-by: Junyoung "Clare" Jang <[email protected]>
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
* Unify showSDocUnsafe * Fix dependency * Add missing instance * Add missing instance * Remove unused imports * Clean up unused code * Remove unnecessary exports & Rename * Unify use printOutputable * Remove redundant import * Replace show with unpack * Rerun tests * Rerun tests Co-authored-by: Pepe Iborra <[email protected]> Co-authored-by: Junyoung "Clare" Jang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We choose
printOutputable :: Outputable a => a -> Textfinally.Extends #2828, this pr wrapped
showSDocUnsafeand unified allSDocprinting functions into the following four functionsshowGhchasdefaultUserStyleandsuppressUnique, we'd use this as much as we can to print ghc internal.showGhcWithUniquesis the alias ofshowSDocUnsafe, it may have different behavior under different ghc versions, like complex type variables in hover with GHC 9.2 #2716.prettyPrintsames asshowGhcbut returnStringinstead ofText.prettyPrintWithUnique, theStringversion ofshowGhcWithUniques.