Skip to content

Fix off by one indexing error in openingBacktick #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2022
Merged

Fix off by one indexing error in openingBacktick #2629

merged 2 commits into from
Jan 23, 2022

Conversation

@pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Jan 23, 2022 •
edited
Loading

Apply the fix suggested by @Bodigrim in #2602 (comment)

Fixes #2602

@pepeiborra pepeiborra mentioned this pull request Jan 23, 2022
Closed
@fendor fendor mentioned this pull request Jan 23, 2022
Closed
jneira
jneira approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pepeiborra pepeiborra self-assigned this Jan 23, 2022
@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Jan 23, 2022
@mergify mergify bot merged commit 22e5ebd into master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jneira jneira jneira approved these changes

Assignees

@pepeiborra pepeiborra

Labels

merge me Label to trigger pull request merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Data.Text.Internal.Fusion.Common.index: Index too large

3 participants

@pepeiborra @jneira