Wingman: Fix TODO(sandy) when performing subsequent actions #2580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isovector
commented
Jan 12, 2022
| deriving stock (Eq, Ord, Show, Generic) | ||
| deriving anyclass (A.ToJSON, A.FromJSON) | ||
|
|
||
| deriving anyclass instance A.ToJSON NormalizedFilePath |
Collaborator
Author
There was a problem hiding this comment.
The problem is pretty obvious when you look at these :)
Collaborator
There was a problem hiding this comment.
Maybe there should be an instance TypeError "Do not do this" => ToJSON NormalizedFilePath definition in the lsp package where NormalizedFilePath is defined, to prevent this weird bug from happening again
Collaborator
There was a problem hiding this comment.
Happy to add that - what goes wrong with it OOI?
Collaborator
There was a problem hiding this comment.
I don't remember anymore. Presumably the derived instances are not roundtripping, i.e. fromJSON . receiveLSP . sendLSP . toJSON /= id, because of the embedded hashes.
pepeiborra
approved these changes
Jan 12, 2022
isovector
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2448, by using
Uriinternally instead ofNormalizedFilePath. It's not clear why it fixes it, since all the functions involved are pure, but who knows. Huge shoutouts to @pepeiborra for tracking down the issue in the first place.