Handle re-exported modules when constructing ExportsMap #2468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
reviewed
Dec 11, 2021
jhrcek
force-pushed
the
jhrcek/handle-module-reexports
branch
from
18ef01a to
08f039f
Compare
pepeiborra
approved these changes
Dec 11, 2021
Collaborator
pepeiborra
left a comment
pepeiborra
left a comment
There was a problem hiding this comment.
Thanks for reporting, diagnosing and fixing this!
Collaborator
Author
|
I don't understand what the failure in the windows job it about. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #2451 based on @pepeiborra 's suggestion: #2451 (comment)
This fixes the issue for me with GHC 8.10.7, let's see how it fares in CI..