Missing newline when evaluate on last line

[t4ccer]

Using Evaluate on

-- >>> take 5 [0..]

produces

-- >>> take 5 [0..]-- [0,1,2,3,4]
<here is newline>

instead of

-- >>> take 5 [0..]
-- [0,1,2,3,4]

when >>> take 5 [0..] is on the last line of file. I believe that appending newline character on beginning of Evaluate's output instead of at the and will solve the issue.

[jneira]

There were some pr's about newlines in the eval plugin, f.e.:

• Preserve the last empty comment line after eval plugin #631

Maybe this is related with them?
//cc @expipiplus1

[expipiplus1]

I can't reproduce this with haskell-language-server version: 0.7.1.0 (GHC: 8.10.3) I think there was some other more recent work done on the eval plugin.

[jneira]

@expipiplus1 many thanks for checking it
@t4ccer could you reproduce it with that version of hls (or the newer one 0.8.0)?

[t4ccer]

Hmm that's interesting, I can still reproduce it using haskell-language-server version: 0.8.0 (GHC: 8.10.1). I used this file as input.

[expipiplus1]

@tittoassini is perhaps a better person to look at this.

[tittoassini]

The problem is that the Eval plugin will instruct the client to add the result in the line after the test.

However, if the line does not exist, the client will attach it to the last line instead.

For File:
0: module TLastLine where
1:
2:-- >>> take 5 [1..]-- [1,2,3,4,5]

We say "put the result on line 3":

{"jsonrpc":"2.0","params":{"edit":{"changes":{"file:///Users/titto/workspace/haskell-language-server/plugins/hls-eval-plugin/test/testdata/TLastLine.hs":[{"range":{"start":{"line":3,"character":0},"end":{"line":3,"character":0}},"newText":"-- [1,2,3,4,5]\n"}]}}},"method":"workspace/applyEdit","id":14}

Clients says: "ok, there is no line 3 so it goes at the end of line 2!":

{"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"file:///Users/titto/workspace/haskell-language-server/plugins/hls-eval-plugin/test/testdata/TLastLine.hs","version":20},"contentChanges":[{"range":{"start":{"line":2,"character":19},"end":{"line":2,"character":19}},"rangeLength":0,"text":"-- [1,2,3,4,5]\n"}]}}