Merge branch 'master' into enable-win-tests

Author: jneira

.github/workflows/test.yml

@@ -138,6 +138,15 @@ jobs:
           sed -i.bak -e 's/Paths_haskell_language_server/Paths_hls/g' \
                      src/**/*.hs exe/*.hs
 
+      # this is only safe if the test environment is isolated
+      - name: setup ide cache
+        run: |
+          export XDG_CACHE_HOME=$RUNNER_TEMP/cache
+          rm -rf ~/.cache/ghcide
+          rm -rf ~/.cache/hie-bios
+          rm -rf $XDG_CACHE_HOME/ghcide
+          rm -rf $XDG_CACHE_HOME/hie-bios
+
       - if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
         name: Build
         # Retry it three times to workaround compiler segfaults in windows

ghcide/src/Development/IDE/Main.hs

@@ -86,7 +86,8 @@ import           GHC.IO.Handle                         (hDuplicate)
 import           HIE.Bios.Cradle                       (findCradle)
 import qualified HieDb.Run                             as HieDb
 import           Ide.Plugin.Config                     (CheckParents (NeverCheck),
-                                                        Config,
+                                                        Config, checkParents,
+                                                        checkProject,
                                                         getConfigFromNotification)
 import           Ide.Plugin.ConfigUtils                (pluginsToDefaultConfig,
                                                         pluginsToVSCodeExtensionSchema)
@@ -193,7 +194,10 @@ defaultArguments priority = Arguments
         , argsGhcidePlugin = mempty
         , argsHlsPlugins = pluginDescToIdePlugins Ghcide.descriptors
         , argsSessionLoadingOptions = def
-        , argsIdeOptions = const defaultIdeOptions
+        , argsIdeOptions = \config ghcSession -> (defaultIdeOptions ghcSession)
+            { optCheckProject = pure $ checkProject config
+            , optCheckParents = pure $ checkParents config
+            }
         , argsLspOptions = def {LSP.completionTriggerCharacters = Just "."}
         , argsDefaultHlsConfig = def
         , argsGetHieDbLoc = getHieDbLoc