Use latest version of fourmolu possible (#3764)

* Remove fourmolu pin in stack.yaml

* Require fourmolu >= 0.9

* Use specific versions of fourmolu for each version of GHC

---------

Co-authored-by: Michael Peyton Jones <[email protected]>

Author: brandonchinn178

plugins/hls-fourmolu-plugin/hls-fourmolu-plugin.cabal

@@ -26,13 +26,11 @@ library
   buildable: True
   exposed-modules:
       Ide.Plugin.Fourmolu
-    , Ide.Plugin.Fourmolu.Shim
   hs-source-dirs:   src
   ghc-options:      -Wall
   build-depends:
     , base            >=4.12 && <5
     , filepath
-    , fourmolu        ^>=0.3 || ^>=0.4 || ^>= 0.6 || ^>= 0.7 || ^>= 0.8 || ^>= 0.9 || ^>= 0.10 || ^>= 0.11 || ^>= 0.12 || ^>= 0.13
     , ghc
     , ghc-boot-th
     , ghcide          == 2.2.0.0
@@ -44,6 +42,15 @@ library
     , text
     , transformers
 
+  if impl(ghc >= 8.10) && impl(ghc < 9.0)
+    build-depends: fourmolu ^>= 0.9
+  elif impl(ghc >= 9.0) && impl(ghc < 9.2)
+    build-depends: fourmolu ^>= 0.11
+  elif impl(ghc >= 9.2) && impl(ghc < 9.8)
+    build-depends: fourmolu ^>= 0.13
+  else
+    buildable: false
+
   -- fourmolu 0.9.0 fails to build on Windows CI for reasons unknown
   if impl(ghc >= 9.2) && os(windows) && impl(ghc < 9.4)
      build-depends: fourmolu > 0.9.0.0 || < 0.9.0.0

plugins/hls-fourmolu-plugin/src/Ide/Plugin/Fourmolu.hs

@@ -34,7 +34,6 @@ import           Development.IDE.GHC.Compat      as Compat hiding (Cpp, Warning,
 import qualified Development.IDE.GHC.Compat.Util as S
 import           GHC.LanguageExtensions.Type     (Extension (Cpp))
 import           Ide.Plugin.Error
-import           Ide.Plugin.Fourmolu.Shim
 import           Ide.Plugin.Properties
 import           Ide.PluginUtils                 (makeDiffTextEdit)
 import           Ide.Types
@@ -43,6 +42,7 @@ import           Language.LSP.Protocol.Message
 import           Language.LSP.Protocol.Types
 import           Language.LSP.Server             hiding (defaultConfig)
 import           Ormolu
+import           Ormolu.Config
 import           System.Exit
 import           System.FilePath
 import           System.Process.Run              (cwd, proc)
@@ -87,9 +87,9 @@ provider recorder plId ideState typ contents fp fo = ExceptT $ withIndefinitePro
                   where
                     printerOpts = cfgFilePrinterOpts fourmoluConfig
                     config =
-                        addFixityOverrides (cfgFileFixities fourmoluConfig) $
                         defaultConfig
                             { cfgDynOptions = map DynOption fileOpts
+                            , cfgFixityOverrides = cfgFileFixities fourmoluConfig
                             , cfgRegion = region
                             , cfgDebug = False
                             , cfgPrinterOpts =
@@ -112,7 +112,7 @@ provider recorder plId ideState typ contents fp fo = ExceptT $ withIndefinitePro
                                 }
                         throwError $ PluginInternalError errorMessage
                       where
-                        errorMessage = "Failed to load " <> T.pack f <> ": " <> T.pack (showParseError err)
+                        errorMessage = "Failed to load " <> T.pack f <> ": " <> T.pack (show err)
   where
     fp' = fromNormalizedFilePath fp
     title = "Formatting " <> T.pack (takeFileName fp')

plugins/hls-fourmolu-plugin/src/Ide/Plugin/Fourmolu/Shim.hs

@@ -46,7 +46,6 @@ extra-deps:
 - hiedb-0.4.3.0
 - implicit-hie-0.1.2.7
 - implicit-hie-cradle-0.5.0.1
-- fourmolu-0.12.0.0
 - algebraic-graphs-0.6.1
 - retrie-1.2.2
 - hw-fingertree-0.1.2.1