Skip to content

Commit 6f55ccb

Browse files
pepeiborrapepeiborra
authored
Add CI flows for 9.4.3 (#3396)
* Add CI for 9.4.3 * exclude in Windows * Workaround fourmolu 0.9.0.0 build failure in windows
1 parent 924b932 commit 6f55ccb

File tree

5 files changed

+27
-22
lines changed

5 files changed

+27
-22
lines changed

‎.github/workflows/caching.yml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,10 @@ jobs:
8282
matrix:
8383
# This list of GHC versions must fit to the list of GHC versions
8484
# specified in 'test.yml'
85-
ghc: [ "9.4.2"
86-
, "9.4.1"
85+
ghc: [ "9.4.3"
86+
, "9.4.2"
8787
, "9.2.5"
8888
, "9.2.4"
89-
, "9.2.3"
9089
, "9.0.2"
9190
, "8.10.7"
9291
]

‎.github/workflows/test.yml‎

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ jobs:
6060
# **don't forget**
6161
# to update the ghc versions in 'caching.yml'.
6262
matrix:
63-
ghc: [ "9.4.2"
64-
, "9.4.1"
63+
ghc: [ "9.4.3"
64+
, "9.4.2"
6565
, "9.2.5"
6666
, "9.2.4"
6767
, "9.2.3"
@@ -80,13 +80,15 @@ jobs:
8080
ghc: '9.4.1'
8181
# Exclude until https://github.com/haskell/actions/issues/129
8282
# is resolved.
83+
- os: windows-latest
84+
ghc: '9.4.3' # Excluded because github action cannot install it
8385
- os: windows-latest
8486
ghc: '9.2.5'
8587
# Mark which GHC versions on which platform we want to test.
8688
include:
8789
# only test supported ghc major versions
8890
- os: ubuntu-latest
89-
ghc: '9.4.2'
91+
ghc: '9.4.3'
9092
test: true
9193
- os: ubuntu-latest
9294
ghc: '9.2.5'
@@ -165,15 +167,15 @@ jobs:
165167
HLS_WRAPPER_TEST_EXE: hls-wrapper
166168
run: cabal test wrapper-test --test-options="$TEST_OPTS --rerun-log-file .tasty-rerun-log-wrapper"
167169

168-
- if: matrix.test && matrix.ghc != '9.2.4' && matrix.ghc != '9.2.5' && matrix.ghc != '9.4.2'
170+
- if: matrix.test && matrix.ghc != '9.2.4' && matrix.ghc != '9.2.5' && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
169171
name: Test hls-brittany-plugin
170172
run: cabal test hls-brittany-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-brittany-plugin --test-options="$TEST_OPTS"
171173

172-
- if: matrix.test && matrix.ghc != '9.4.2'
174+
- if: matrix.test && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
173175
name: Test hls-refactor-plugin
174176
run: cabal test hls-refactor-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-refactor-plugin --test-options="$TEST_OPTS"
175177

176-
- if: matrix.test && matrix.ghc != '9.4.2'
178+
- if: matrix.test && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
177179
name: Test hls-floskell-plugin
178180
run: cabal test hls-floskell-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-floskell-plugin --test-options="$TEST_OPTS"
179181

@@ -185,31 +187,31 @@ jobs:
185187
name: Test hls-pragmas-plugin
186188
run: cabal test hls-pragmas-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-pragmas-plugin --test-options="$TEST_OPTS"
187189

188-
- if: matrix.test && matrix.ghc != '9.4.2'
190+
- if: matrix.test && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
189191
name: Test hls-eval-plugin
190192
run: cabal test hls-eval-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-eval-plugin --test-options="$TEST_OPTS"
191193

192-
- if: matrix.test && matrix.ghc != '9.2.4' && matrix.ghc != '9.2.5' && matrix.ghc != '9.4.2'
194+
- if: matrix.test && matrix.ghc != '9.2.4' && matrix.ghc != '9.2.5' && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
193195
name: Test hls-haddock-comments-plugin
194196
run: cabal test hls-haddock-comments-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-haddock-comments-plugin --test-options="$TEST_OPTS"
195197

196-
- if: matrix.test && matrix.ghc != '9.4.2'
198+
- if: matrix.test && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
197199
name: Test hls-splice-plugin
198200
run: cabal test hls-splice-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-splice-plugin --test-options="$TEST_OPTS"
199201

200-
- if: matrix.test && matrix.ghc != '9.4.2'
202+
- if: matrix.test && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
201203
name: Test hls-stylish-haskell-plugin
202204
run: cabal test hls-stylish-haskell-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-stylish-haskell-plugin --test-options="$TEST_OPTS"
203205

204-
- if: matrix.test && matrix.ghc != '9.4.2'
206+
- if: matrix.test && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
205207
name: Test hls-ormolu-plugin
206208
run: cabal test hls-ormolu-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-ormolu-plugin --test-options="$TEST_OPTS"
207209

208-
- if: matrix.test && matrix.ghc != '9.4.2'
210+
- if: matrix.test && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
209211
name: Test hls-fourmolu-plugin
210212
run: cabal test hls-fourmolu-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-fourmolu-plugin --test-options="$TEST_OPTS"
211213

212-
- if: matrix.test && matrix.ghc != '9.2.4' && matrix.ghc != '9.2.5' && matrix.ghc != '9.4.2'
214+
- if: matrix.test && matrix.ghc != '9.2.4' && matrix.ghc != '9.2.5' && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
213215
name: Test hls-tactics-plugin test suite
214216
run: cabal test hls-tactics-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-tactics-plugin --test-options="$TEST_OPTS"
215217

@@ -225,15 +227,15 @@ jobs:
225227
name: Test hls-call-hierarchy-plugin test suite
226228
run: cabal test hls-call-hierarchy-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-call-hierarchy-plugin --test-options="$TEST_OPTS"
227229

228-
- if: matrix.test && matrix.os != 'windows-latest' && matrix.ghc != '9.4.2'
230+
- if: matrix.test && matrix.os != 'windows-latest' && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
229231
name: Test hls-rename-plugin test suite
230232
run: cabal test hls-rename-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-rename-plugin --test-options="$TEST_OPTS"
231233

232-
- if: matrix.test && matrix.ghc != '9.4.2'
234+
- if: matrix.test && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
233235
name: Test hls-hlint-plugin test suite
234236
run: cabal test hls-hlint-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-hlint-plugin --test-options="$TEST_OPTS"
235237

236-
- if: matrix.test && matrix.ghc != '9.0.1' && matrix.ghc != '9.0.2' && matrix.ghc != '9.2.4' && matrix.ghc != '9.2.5' && matrix.ghc != '9.4.2'
238+
- if: matrix.test && matrix.ghc != '9.0.1' && matrix.ghc != '9.0.2' && matrix.ghc != '9.2.4' && matrix.ghc != '9.2.5' && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
237239
name: Test hls-stan-plugin test suite
238240
run: cabal test hls-stan-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-stan-plugin --test-options="$TEST_OPTS"
239241

@@ -249,15 +251,15 @@ jobs:
249251
name: Test hls-qualify-imported-names-plugin test suite
250252
run: cabal test hls-qualify-imported-names-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-qualify-imported-names-plugin --test-options="$TEST_OPTS"
251253

252-
- if: matrix.test && matrix.ghc != '9.4.2'
254+
- if: matrix.test && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
253255
name: Test hls-code-range-plugin test suite
254256
run: cabal test hls-code-range-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-code-range-plugin --test-options="$TEST_OPTS"
255257

256258
- if: matrix.test
257259
name: Test hls-change-type-signature test suite
258260
run: cabal test hls-change-type-signature-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-change-type-signature-plugin --test-options="$TEST_OPTS"
259261

260-
- if: matrix.test && matrix.ghc != '9.4.2'
262+
- if: matrix.test && matrix.ghc != '9.4.2' && matrix.ghc != '9.4.3'
261263
name: Test hls-gadt-plugin test suit
262264
run: cabal test hls-gadt-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-gadt-plugin --test-options="$TEST_OPTS"
263265

‎cabal.project‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ package *
5151

5252
write-ghc-environment-files: never
5353

54-
index-state: 2022-10-07T12:19:15Z
54+
index-state: 2022-12-13T21:00:15Z
5555

5656
constraints:
5757
-- For GHC 9.4, older versions of entropy fail to build on Windows

‎docs/support/ghc-version-support.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ Support status (see the support policy below for more details):
1717

1818
| GHC version | Last supporting HLS version | Support status |
1919
|--------------|------------------------------------------------------------------------------------|-----------------------------------------------------------------------------|
20+
| 9.4.3 | unreleased | basic support |
2021
| 9.4.2 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | basic support |
2122
| 9.4.1 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | basic support |
2223
| 9.2.5 | unreleased | full support |

‎plugins/hls-fourmolu-plugin/hls-fourmolu-plugin.cabal‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ library
4545
, process-extras >= 0.7.1
4646
, text
4747

48+
-- fourmolu 0.9.0 fails to build on Windows CI for reasons unknown
49+
if impl(ghc >= 9.2) && os(windows) && impl(ghc < 9.4)
50+
build-depends: fourmolu > 0.9.0.0 || < 0.9.0.0
4851
default-language: Haskell2010
4952

5053
test-suite tests

0 commit comments

Comments
 (0)