Skip to content

Add -json flag to quota inspect command #16478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 20, 2023
Merged

Add -json flag to quota inspect command #16478

merged 6 commits into from
Mar 20, 2023

Conversation

@Juanadelacuesta
Copy link
Member

No description provided.

@Juanadelacuesta Juanadelacuesta force-pushed the b-json-and-t-flag-quota-inspect branch from 15fb957 to b80bfae Compare March 14, 2023 12:50
@Juanadelacuesta Juanadelacuesta requested a review from jrasell March 14, 2023 12:57
@jrasell jrasell added this to the 1.5.x milestone Mar 14, 2023
@jrasell jrasell added the backport/1.5.x backport to 1.5.x release line label Mar 14, 2023
@Juanadelacuesta Juanadelacuesta force-pushed the b-json-and-t-flag-quota-inspect branch from 606a823 to caaa0ef Compare March 14, 2023 16:05
jrasell
jrasell requested changes Mar 15, 2023
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. Just a minor couple of suggestions. Thanks for also fixing up the typos you found along the way!

Juanadelacuesta and others added 2 commits March 15, 2023 14:30
@vercel
Copy link

vercel bot commented Mar 15, 2023

Deployment failed with the following error:

Was unable to schedule a deployment.

@Juanadelacuesta Juanadelacuesta requested a review from jrasell March 15, 2023 13:31
jrasell
jrasell approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrasell jrasell mentioned this pull request Mar 16, 2023
Open
15 tasks
@Juanadelacuesta Juanadelacuesta merged commit cc110f4 into main Mar 20, 2023
@Juanadelacuesta Juanadelacuesta deleted the b-json-and-t-flag-quota-inspect branch March 20, 2023 09:40
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Mar 20, 2023
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrasell jrasell jrasell approved these changes

Assignees

No one assigned

Labels

backport/1.5.x backport to 1.5.x release line

Projects

None yet

Milestone

1.5.x

Development

Successfully merging this pull request may close these issues.

2 participants

@Juanadelacuesta @jrasell