Skip to content

Commit 76249c3

Browse files
committed
Merge pull request #305 from uk-ar/fix-execution-result-in-rspec3
Fix execution_result to fit RSpec3
2 parents 83a4a66 + dd7067f commit 76249c3

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

lib/guard/rspec_formatter.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,11 @@ def _write(&block)
9292

9393
def _failed_paths
9494
failed = examples.select do |e|
95-
e.execution_result[:status].to_s == "failed"
95+
if self.class.rspec_3?
96+
e.execution_result.status.to_s == "failed"
97+
else
98+
e.execution_result[:status].to_s == "failed"
99+
end
96100
end
97101

98102
klass = self.class

spec/lib/guard/rspec_formatter_spec.rb

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@
5454
)
5555
end
5656

57+
before do
58+
allow(formatter.class).to receive(:rspec_3?).and_return(false)
59+
end
60+
5761
def expected_output(spec_filename)
5862
/^3 examples, 1 failures in 123\.0 seconds\n#{spec_filename}\n$/
5963
end
@@ -81,6 +85,13 @@ def expected_output(spec_filename)
8185
allow(formatter.class).to receive(:rspec_3?).and_return(true)
8286
end
8387

88+
let(:failed_example) do
89+
double(
90+
execution_result: double(status: "failed"),
91+
metadata: { location: spec_filename }
92+
)
93+
end
94+
8495
it "writes summary line and failed location" do
8596
allow(formatter).to receive(:examples) { [failed_example] }
8697
formatter.dump_summary(notification)

0 commit comments

Comments
 (0)